From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CA8C43331 for ; Tue, 12 Nov 2019 16:48:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F6892196E for ; Tue, 12 Nov 2019 16:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbfKLQs1 (ORCPT ); Tue, 12 Nov 2019 11:48:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:58802 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726008AbfKLQs0 (ORCPT ); Tue, 12 Nov 2019 11:48:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4E28EB090; Tue, 12 Nov 2019 16:48:25 +0000 (UTC) Date: Tue, 12 Nov 2019 17:48:25 +0100 Message-ID: From: Takashi Iwai To: Henry Lin Cc: Jaroslav Kysela , Greg Kroah-Hartman , Allison Randal , "Thomas Gleixner" , Richard Fontana , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb-audio: not submit urb for stopped endpoint In-Reply-To: References: <20191112065108.7766-1-henryl@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Nov 2019 17:41:42 +0100, Henry Lin wrote: > > > Ah, I see. Then you don't have to write up the full stack trace like > > the above. It's confusing as if it were some kernel Oops or WARNING. > Got it. Should I post another patch set here for removing these confusing description in commit message? Or you can help to remove them before merging? Please resubmit after rephrasing the patch description. > > BTW, with your patch, is the error in the first line ("timeout: still > > 1 active urbs on EP #1") also fixed? > Yes, "timeout: still 1 active urbs on EP #1" will be fixed as well. OK, then this should be mentioned in the patch description. Actually the patch fixes this kind of error (the stall at the concurrent stream stop). thanks, Takashi