From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58873C282DD for ; Thu, 23 May 2019 12:26:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B39321019 for ; Thu, 23 May 2019 12:26:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730749AbfEWM0C (ORCPT ); Thu, 23 May 2019 08:26:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:34666 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729762AbfEWM0B (ORCPT ); Thu, 23 May 2019 08:26:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 35B45ADDD; Thu, 23 May 2019 12:25:59 +0000 (UTC) Date: Thu, 23 May 2019 14:25:58 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Cc: Randy Dunlap , LKML , moderated for non-subscribers , Liam Girdwood , Mark Brown , Jie Yang Subject: Re: [alsa-devel] [PATCH] ASoC: sound/soc/intel/boards: limit some drivers to X86 since headers are only in arch/x86/ In-Reply-To: References: <46dc0767-bb21-2b98-90f2-34dd4bcad7c0@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 23 May 2019 13:20:05 +0200, Pierre-Louis Bossart wrote: > > > > On 5/22/19 10:58 PM, Randy Dunlap wrote: > > From: Randy Dunlap > > > > Several drivers in sound/soc/intel/boards/ #include header files > > that only exist in arch/x86/include/asm. This causes build errors, > > so make these drivers depend on X86. > > > > Fixes these build errors (on ia64): > > > > ../sound/soc/intel/boards/bxt_da7219_max98357a.c:19:10: fatal error: asm/cpu_device_id.h: No such file or directory > > #include > > ../sound/soc/intel/boards/bytcr_rt5640.c:31:10: fatal error: asm/cpu_device_id.h: No such file or directory > > #include > > ../sound/soc/intel/boards/bytcr_rt5651.c:33:10: fatal error: asm/cpu_device_id.h: No such file or directory > > #include > > ../sound/soc/intel/boards/cht_bsw_rt5645.c:29:10: fatal error: asm/cpu_device_id.h: No such file or directory > > #include > > ../sound/soc/intel/boards/bytcht_es8316.c:33:10: fatal error: asm/cpu_device_id.h: No such file or directory > > #include > > ../sound/soc/intel/boards/bytcht_da7213.c:26:10: fatal error: asm/platform_sst_audio.h: No such file or directory > > #include > > > > And more drivers determined by: > >> grep "include.*asm.cpu_device_id.h" *.c > > bxt_da7219_max98357a.c:#include > > bytcht_es8316.c:#include > > bytcr_rt5640.c:#include > > bytcr_rt5651.c:#include > > cht_bsw_rt5645.c:#include > > sof_rt5682.c:#include > > and > >> grep "include.*asm.platform_sst_audio.h" *.c > > bytcht_da7213.c:#include > > bytcht_es8316.c:#include > > > > Signed-off-by: Randy Dunlap > > Cc: Mark Brown > > Cc: Pierre-Louis Bossart > > Cc: Liam Girdwood > > Cc: Jie Yang > > Cc: alsa-devel@alsa-project.org > > --- > > sound/soc/intel/boards/Kconfig | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > --- lnx-52-rc1.orig/sound/soc/intel/boards/Kconfig > > +++ lnx-52-rc1/sound/soc/intel/boards/Kconfig > > @@ -87,6 +87,7 @@ config SND_SOC_INTEL_BYTCR_RT5640_MACH > > tristate "Baytrail and Baytrail-CR with RT5640 codec" > > depends on I2C && ACPI > > depends on X86_INTEL_LPSS || COMPILE_TEST > > + depends on X86 > > How does this improve the results? > > config X86_INTEL_LPSS > bool "Intel Low Power Subsystem Support" > depends on X86 && ACPI && PCI > > So the X86 dependency is already there. Does this happen with > COMPILE_TEST set? If yes, maybe that's the part that needs to be > changed? The addition of COMPILE_TEST here is quite recent and might > need to be reverted. Right, the removal of COMPILE_TEST for drivers that require X86_INTEL_LPSS would be more straightforward. thanks, Takashi