From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754478AbeBNGrn (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Feb 2018 01:47:43 -0500
Received: from mx2.suse.de ([195.135.220.15]:41045 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754458AbeBNGrm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Feb 2018 01:47:42 -0500
Date: Wed, 14 Feb 2018 07:47:40 +0100
Message-ID: <s5htvuk1303.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: " Maciej S. Szmigiero " <mail@maciej.szmigiero.name>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
        "linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/5] ALSA: emu10k1: remove reserved_page
In-Reply-To: <87e066a9-99ec-31a4-111a-1d848b7d98ec@maciej.szmigiero.name>
References: <87e066a9-99ec-31a4-111a-1d848b7d98ec@maciej.szmigiero.name>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 14 Feb 2018 00:04:58 +0100,
 Maciej S. Szmigiero  wrote:
> 
> The emu10k1-family chips need the first page (index 0) reserved in their
> page tables for some reason (every emu10k1 driver I've checked does this
> without much of an explanation).
> Using the first page for normal samples results in a broken playback.
> 
> However, we already have a dummy page allocated - so called "silent page"
> and, in fact, had always been setting it as the first page in the chip page
> table because an initialization of every entry of the page table to point
> to a silent page happens after and overwrites the reserved_page allocation.
> 
> So the only thing remaining to remove the reserved_page allocation is a
> trivial change to the page allocation logic to ignore the first page entry
> and start its allocations from the second entry (index 1).
> 
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> ---
> Changes from v1, v2: None in this patch.

Thanks, applied all 5 patches now.


Takashi