From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932964AbcFON3x (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 09:29:53 -0400
Received: from mx2.suse.de ([195.135.220.15]:59148 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932921AbcFON3v (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 09:29:51 -0400
Date: Wed, 15 Jun 2016 15:29:49 +0200
Message-ID: <s5htwgupoky.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Amitoj Kaur Chawla" <amitoj1606@gmail.com>
Cc: <alsa-devel@alsa-project.org>, <perex@perex.cz>,
        <linux-kernel@vger.kernel.org>, <keescook@chromium.org>,
        <michael.leibowitz@intel.com>, <julia.lawall@lip6.fr>
Subject: Re: [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style
In-Reply-To: <20160615132634.GA20438@amitoj-Inspiron-3542>
References: <20160615132634.GA20438@amitoj-Inspiron-3542>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 15 Jun 2016 15:26:34 +0200,
Amitoj Kaur Chawla wrote:
> 
> Replace the in order struct initialisation style with explicit field
> style.
> 
> The Coccinelle semantic patch used to make this change is as follows:
> 
> @decl@
> identifier i1,fld;
> type T;
> field list[n] fs;
> @@
> 
> struct i1 {
>  fs
>  T fld;
>  ...};
> 
> @@
> identifier decl.i1,i2,decl.fld;
> expression e;
> position bad.p, bad.fix;
> @@
> 
> struct i1 i2@p = { ...,
> + .fld = e
> - e@fix
>  ,...};
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  sound/usb/mixer_maps.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
> index 1f8fb0d9..9038b2e 100644
> --- a/sound/usb/mixer_maps.c
> +++ b/sound/usb/mixer_maps.c
> @@ -107,8 +107,10 @@ static struct usbmix_name_map extigy_map[] = {
>   * e.g. no Master and fake PCM volume
>   *			Pavel Mihaylov <bin@bash.info>
>   */
> -static struct usbmix_dB_map mp3plus_dB_1 = {-4781, 0};	/* just guess */
> -static struct usbmix_dB_map mp3plus_dB_2 = {-1781, 618}; /* just guess */
> +static struct usbmix_dB_map mp3plus_dB_1 = {.min = -4781, .max = 0};
> +						/* just guess */
> +static struct usbmix_dB_map mp3plus_dB_2 = {.min = -1781, .max = 618};
> +						/* just guess */

These are simple min/max table, so no big merit to write in such a
way.


thanks,

Takashi