From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755342AbcARNgq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jan 2016 08:36:46 -0500
Received: from mx2.suse.de ([195.135.220.15]:55866 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755309AbcARNgd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jan 2016 08:36:33 -0500
Date: Mon, 18 Jan 2016 14:36:30 +0100
Message-ID: <s5htwmbt3fl.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: alsa-devel@alsa-project.org, Jie Yang <yang.jie@intel.com>,
        Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        LKML <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Alexander Potapenko <glider@google.com>,
        Kostya Serebryany <kcc@google.com>,
        syzkaller <syzkaller@googlegroups.com>,
        Sasha Levin <sasha.levin@oracle.com>
Subject: Re: sound: use-after-free in snd_timer_interrupt
In-Reply-To: <CACT4Y+bVVxUeqZnwAbLwT3dCGcpRMG9B8WZMv3jk3SHjwMWW2w@mail.gmail.com>
References: <CACT4Y+ZrVvE3dgcYHRdHDG0X316VgC-=pr2U-233vVn_QbHZHw@mail.gmail.com>
	<s5hwprdv2sp.wl-tiwai@suse.de>
	<CACT4Y+ZFsNxsVyq_n6kh=HN1dStj_hL=B9eUu4heAHes=ixf3g@mail.gmail.com>
	<s5hio2xmh9z.wl-tiwai@suse.de>
	<CACT4Y+bqxg_C7JmnUSRm_9jiZ9R9XqbBV0igDdUW1ZhtqvktJw@mail.gmail.com>
	<CACT4Y+anWgMKQmNByifCs+-jizRQL9twxvRQzW3XzNJ8+a6fDw@mail.gmail.com>
	<s5hegdlmdd6.wl-tiwai@suse.de>
	<CACT4Y+Y62DTncEAb_S6JykY7Ps7SHo2QyCopMObBxJt2fB_NKA@mail.gmail.com>
	<s5h60yxmc99.wl-tiwai@suse.de>
	<s5ha8o8uoqb.wl-tiwai@suse.de>
	<CACT4Y+a-=mrGALS+yf4GwGmJGLWXVJ0mbucPAkZ7WSGFaSR0Kw@mail.gmail.com>
	<s5hwprbt8ei.wl-tiwai@suse.de>
	<CACT4Y+ZfAc1JZQHHbA-k_ZVN3vm9djojvmL+e=D8WO2J8FR0=A@mail.gmail.com>
	<s5hk2nbt0gp.wl-tiwai@suse.de>
	<CACT4Y+aOEHHEVp1YLLMr2PD_iyESMP64T-EQX18=EfvRtgOLOQ@mail.gmail.com>
	<CACT4Y+YPVUCTenSZjLfMf08NHJm1u3--Qm6a32oTdCmxUGkC0Q@mail.gmail.com>
	<s5hk2natzwn.wl-tiwai@suse.de>
	<CACT4Y+Yq+yPRGw=+rzcWgKgUkK3qwRw2+miiPQ3amSO3cJ1DGw@mail.gmail.com>
	<s5hfuxytu55.wl-tiwai@suse.de>
	<s5hd1t2tt4q.wl-tiwai@suse.de>
	<CACT4Y+Zg4DkCJEORWAfY1ZasCs8GFkbBxTQFNZdHx+4XG_zRWg@mail.gmail.com>
	<s5h4mebujel.wl-tiwai@suse.de>
	<CACT4Y+bVVxUeqZnwAbLwT3dCGcpRMG9B8WZMv3jk3SHjwMWW2w@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 18 Jan 2016 14:30:13 +0100,
Dmitry Vyukov wrote:
> 
> On Mon, Jan 18, 2016 at 2:06 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >> No, unfortunately the hang still happens with the patch:
> >
> > Thanks for testing.  I think I understood the problem.  We faced a
> > similar issue and moved hrtimer_cancel() in the past.  But this wasn't
> > enough, as the start function may be called also in interrupt, too.
> >
> > How about the one below instead?
> 
> 
> Yes, this fixes the hang. Thanks!
> 
> Tested-by: Dmitry Vyukov <dvyukov@google.com>

Great, I'll queue the fix.
Thanks for patient testing!


Takashi