From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030869AbbJ3Ld5 (ORCPT ); Fri, 30 Oct 2015 07:33:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:54503 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030377AbbJ3Ld4 (ORCPT ); Fri, 30 Oct 2015 07:33:56 -0400 Date: Fri, 30 Oct 2015 12:33:54 +0100 Message-ID: From: Takashi Iwai To: "Ondrej Zary" Cc: , "Kernel development list" Subject: Re: [PATCH] snd-cs46xx: Fix Duplicate front for CS4294 and CS4298 codecs In-Reply-To: <1446146526-21579-1-git-send-email-linux@rainbow-software.org> References: <1446146526-21579-1-git-send-email-linux@rainbow-software.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Oct 2015 20:22:06 +0100, Ondrej Zary wrote: > > Currently, the Duplicate front control is enabled only for two specific > revisions of CS4294. > > Enable it for all CS4294 and CS4298 codecs instead. > > This fixes rear output on my VC-4620N sound card > (CS4620 + CS4298 rev.5). > > Signed-off-by: Ondrej Zary Applied, thanks. Takashi > --- > sound/pci/cs46xx/cs46xx_lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/cs46xx/cs46xx_lib.c b/sound/pci/cs46xx/cs46xx_lib.c > index 2a9f4a3..e62c841 100644 > --- a/sound/pci/cs46xx/cs46xx_lib.c > +++ b/sound/pci/cs46xx/cs46xx_lib.c > @@ -2528,7 +2528,7 @@ int snd_cs46xx_mixer(struct snd_cs46xx *chip, int spdif_device) > #ifdef CONFIG_SND_CS46XX_NEW_DSP > if (chip->nr_ac97_codecs == 1) { > unsigned int id2 = chip->ac97[CS46XX_PRIMARY_CODEC_INDEX]->id & 0xffff; > - if (id2 == 0x592b || id2 == 0x592d) { > + if ((id2 & 0xfff0) == 0x5920) { /* CS4294 and CS4298 */ > err = snd_ctl_add(card, snd_ctl_new1(&snd_cs46xx_front_dup_ctl, chip)); > if (err < 0) > return err; > -- > Ondrej Zary > > . >