From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbbCIMas (ORCPT ); Mon, 9 Mar 2015 08:30:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33225 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbbCIMaq (ORCPT ); Mon, 9 Mar 2015 08:30:46 -0400 Date: Mon, 09 Mar 2015 13:30:44 +0100 Message-ID: From: Takashi Iwai To: Fengguang Wu Cc: LKP , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [ALSA/hda] kernel BUG at drivers/base/driver.c:152! In-Reply-To: <20150307105844.GA24355@wfg-t540p.sh.intel.com> References: <20150307105844.GA24355@wfg-t540p.sh.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 7 Mar 2015 18:58:44 +0800, Fengguang Wu wrote: > > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/hda-regmap > > commit 3103d80b8a89f1797e87d7265f9b389a0db4ccd8 > Author: Takashi Iwai > AuthorDate: Tue Feb 17 21:46:37 2015 +0100 > Commit: Takashi Iwai > CommitDate: Tue Mar 3 14:35:44 2015 +0100 > > ALSA: hda - Make snd_hda_bus_type public > > Define the common hd-audio driver and device types to bind over > snd_hda_bus_type publicly. This allows to implement other type of > device and driver code over hd-audio bus. > > Now both struct hda_codec and struct hda_codec_driver inherit these > new struct hdac_device and struct hdac_driver, respectively. > > Signed-off-by: Takashi Iwai Fixed by the patch below now. Thanks! Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: hda - Fix panic at booting with built-in HDA driver The split of hdaudio bus type caused a kernel panic at booting when the HD-audio driver is built into kernel, because of the insufficient init call order. This patch changes the module_init() to subsys_initcall() to assure the bus type registration done before any other driver registrations. Reported-by: Fengguang Wu Signed-off-by: Takashi Iwai --- sound/hda/hda_bus_type.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/hda/hda_bus_type.c b/sound/hda/hda_bus_type.c index 996515c6a248..519914a12e8a 100644 --- a/sound/hda/hda_bus_type.c +++ b/sound/hda/hda_bus_type.c @@ -38,5 +38,5 @@ static void __exit hda_bus_exit(void) bus_unregister(&snd_hda_bus_type); } -module_init(hda_bus_init); +subsys_initcall(hda_bus_init); module_exit(hda_bus_exit); -- 2.3.2