From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751043AbbACJ7f (ORCPT ); Sat, 3 Jan 2015 04:59:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:55107 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbbACJ7e (ORCPT ); Sat, 3 Jan 2015 04:59:34 -0500 Date: Sat, 03 Jan 2015 10:59:29 +0100 Message-ID: From: Takashi Iwai To: Chen Gang Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] sound: soc: soc-pcm: Remove useless varialbe 'i' In-Reply-To: <54A7BA55.3020607@sunrus.com.cn> References: <54A7BA55.3020607@sunrus.com.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sat, 03 Jan 2015 17:45:57 +0800, Chen Gang wrote: > > 'i' is useless in soc_pcm_set_msb(), so remove it, the related warning > (with allmodconfig under s390): > > CC [M] sound/soc/soc-pcm.o > sound/soc/soc-pcm.c: In function 'soc_pcm_set_msb': > sound/soc/soc-pcm.c:307:11: warning: unused variable 'i' [-Wunused-variable] > int ret, i; > ^ Thanks, but this was already fixed. Takashi > > Signed-off-by: Chen Gang > --- > sound/soc/soc-pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c > index d6e8d6b..6b0136e 100644 > --- a/sound/soc/soc-pcm.c > +++ b/sound/soc/soc-pcm.c > @@ -304,7 +304,7 @@ static bool soc_pcm_has_symmetry(struct snd_pcm_substream *substream) > static void soc_pcm_set_msb(struct snd_pcm_substream *substream, int bits) > { > struct snd_soc_pcm_runtime *rtd = substream->private_data; > - int ret, i; > + int ret; > > if (!bits) > return; > -- > 1.7.9.5 >