From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965223AbaKNLEC (ORCPT ); Fri, 14 Nov 2014 06:04:02 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57735 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964781AbaKNLD7 (ORCPT ); Fri, 14 Nov 2014 06:03:59 -0500 Date: Fri, 14 Nov 2014 12:03:58 +0100 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] ALSA: ice1712: consider error value In-Reply-To: <20141114105915.GA10385@sudip-PC> References: <1415961547-10330-1-git-send-email-sudipm.mukherjee@gmail.com> <1415961547-10330-2-git-send-email-sudipm.mukherjee@gmail.com> <20141114105915.GA10385@sudip-PC> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 14 Nov 2014 16:29:15 +0530, Sudip Mukherjee wrote: > > On Fri, Nov 14, 2014 at 11:43:31AM +0100, Takashi Iwai wrote: > > At Fri, 14 Nov 2014 16:09:06 +0530, > > Sudip Mukherjee wrote: > > > > > > earlier we were ignoring the return value of snd_ak4114_create and > > > always returning 0. > > > now we are returning the actual status. revo_init is calling this > > > function, and revo_init is checking the return value. > > > > It's not enough only to change there. The problem is that > > spec->ak4114 is dereferenced after snd_ak4114_create(), and this might > > be NULL. So it should return the error before that point. > > > > oops .. i should have looked carefully. > > one more thought: > shouldn't we also do a kfree(spec) on error ? Not necessary. It's freed in the card's destructor. Takashi > > thanks > sudip > > > > > Takashi > > > > > > > Signed-off-by: Sudip Mukherjee > > > --- > > > sound/pci/ice1712/revo.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c > > > index 1112ec1..2835196 100644 > > > --- a/sound/pci/ice1712/revo.c > > > +++ b/sound/pci/ice1712/revo.c > > > @@ -498,7 +498,7 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice) > > > * No reason to stop capture stream due to incorrect checks */ > > > spec->ak4114->check_flags = AK4114_CHECK_NO_RATE; > > > > > > - return 0; /* error ignored; it's no fatal error */ > > > + return err; > > > } > > > > > > static int revo_init(struct snd_ice1712 *ice) > > > -- > > > 1.8.1.2 > > > >