From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755133AbaHEQBU (ORCPT ); Tue, 5 Aug 2014 12:01:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52093 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753179AbaHEQBT (ORCPT ); Tue, 5 Aug 2014 12:01:19 -0400 Date: Tue, 05 Aug 2014 18:01:18 +0200 Message-ID: From: Takashi Iwai To: Jean-Michel Hautbois Cc: B_B_Singh@dell.com, Greg KH , Abhay_Salunke@dell.com, Arnd Bergmann , kay@vrfy.org, ming.lei@canonical.com, Stefan Roese , teg@jklm.no, Stuart_Hayes@dell.com, Srinivas_G_Gowda@dell.com, linux-kernel Subject: Re: patch "firmware loader: allow disabling of udev as firmware loader" added to driver-core tree In-Reply-To: References: <14048583172593@kroah.com> <8B2F6FFD0BD1E448853114367400A37306FD6FBBE9@BLRX7MCDC203.AMER.DELL.COM> <8B2F6FFD0BD1E448853114367400A37306FD6FBBF8@BLRX7MCDC203.AMER.DELL.COM> <8B2F6FFD0BD1E448853114367400A37306FD6FBC06@BLRX7MCDC203.AMER.DELL.COM> <8B2F6FFD0BD1E448853114367400A37306FD6FBDAB@BLRX7MCDC203.AMER.DELL.COM> <8B2F6FFD0BD1E448853114367400A37306FE07C773@BLRX7MCDC203.AMER.DELL.COM> <8B2F6FFD0BD1E448853114367400A37306FE07CC64@BLRX7MCDC203.AMER.DELL.COM> <8B2F6FFD0BD1E448853114367400A37306FE311D74@BLRX7MCDC203.AMER.DELL.COM> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 5 Aug 2014 17:55:40 +0200, Jean-Michel Hautbois wrote: > > 2014-08-05 17:53 GMT+02:00 Takashi Iwai : > > At Tue, 5 Aug 2014 17:43:17 +0200, > > Jean-Michel Hautbois wrote: > >> > >> 2014-08-01 22:01 GMT+02:00 : > >> > Hi Takashi, > >> > > >> > Sorry for the late response, I tried with latest stable kernel 3.15.8. surprisingly the BIOS update works even without applying the patch in both the cases. > >> > >> Hi,I'm sorry for my late answer too, but I didn't try this patch recently... > >> > >> I have a Lattice FPGA on my board, and it seems that your patch breaks > >> the firmware loading. > >> I have the following config : > >> CONFIG_FW_LOADER=y > >> CONFIG_FW_LOADER_USER_HELPER=n > >> FW_LOADER_USER_HELPER_FALLBACK=n > >> LATTICE_ECP3_CONFIG=y > > > > It worked before applying my patch properly...? > > > > The kernel Oops itself is a bug in lattice-ecp3-config driver. > > It blindly assumes that the returned firmware is non-NULL. > > firmware_load() must have a NULL check of fw at the beginning. > > > > > > thanks, > > > > Takashi > > Yes, it worked, if the firmware was in the /lib/firmware directory. Then double-check whether it's really my patch who broke. In your kernel log: [ 1.188285] lattice-ecp3 spi2.3: Direct firmware load for lattice-ecp3.bit failed with error -2 which indicates that the direct f/w loading from /lib/firmware failed. Since this code path is called no matter which kernel option is set, the failure is very unlikely by my patch. Takashi > You are right, it lacks a NULL check, I will fix that. > > Thanks, > JM >