From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752455Ab2JVJA0 (ORCPT ); Mon, 22 Oct 2012 05:00:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58844 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873Ab2JVJAZ (ORCPT ); Mon, 22 Oct 2012 05:00:25 -0400 Date: Mon, 22 Oct 2012 11:00:17 +0200 Message-ID: From: Takashi Iwai To: Wei Yongjun Cc: perex@perex.cz, yongjun_wei@trendmicro.com.cn, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda - remove unused variable in azx_position_ok() In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 22 Oct 2012 16:30:10 +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > The variable stream is initialized but never used > otherwise, so remove the unused variable. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun Thanks, applied. Takashi > --- > sound/pci/hda/hda_intel.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 72b085a..0ceed85 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2193,13 +2193,11 @@ static int azx_position_ok(struct azx *chip, struct azx_dev *azx_dev) > { > u32 wallclk; > unsigned int pos; > - int stream; > > wallclk = azx_readl(chip, WALLCLK) - azx_dev->start_wallclk; > if (wallclk < (azx_dev->period_wallclk * 2) / 3) > return -1; /* bogus (too early) interrupt */ > > - stream = azx_dev->substream->stream; > pos = azx_get_position(chip, azx_dev, true); > > if (WARN_ONCE(!azx_dev->period_bytes, >