From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754680Ab2DJGI7 (ORCPT ); Tue, 10 Apr 2012 02:08:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48464 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753245Ab2DJGI6 (ORCPT ); Tue, 10 Apr 2012 02:08:58 -0400 Date: Tue, 10 Apr 2012 08:08:56 +0200 Message-ID: From: Takashi Iwai To: Stephen Warren Cc: Fengguang Wu , alsa-devel@alsa-project.org, Nick Bowler , Linux Kernel Mailing List , Keith Packard Subject: Re: [PATCH] alsa: hide HDMI/ELD printks unless in debug kernels In-Reply-To: <4F82FC6C.1090501@wwwdotorg.org> References: <20120409021517.GA14618@localhost> <4F82FC6C.1090501@wwwdotorg.org> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 09 Apr 2012 09:12:44 -0600, Stephen Warren wrote: > > On 04/08/2012 08:15 PM, Fengguang Wu wrote: > > These trivial messages will show up repeatedly on hot plug as well as > > video mode changes, which could be annoying. > > > > Signed-off-by: Wu Fengguang > > Those messages are very useful for end-users to diagnose problems with > HDMI audio. Is there a way to make the messages dynamic, so users can > get them if they want, without recompiling their kernel? We can define a new macro like below, add call like _snd_printd(2, ....) instead of snd_printd(). (Yes, the number 2 can be replaced better in an enum, too.) In future, we should move to the standard dynamic_printk, but a patch like this would be a good compromise for merging to 3.4 kernel, IMO. Takashi --- diff --git a/include/sound/core.h b/include/sound/core.h index b6e0f57..442f822 100644 --- a/include/sound/core.h +++ b/include/sound/core.h @@ -354,6 +354,8 @@ void __snd_printk(unsigned int level, const char *file, int line, */ #define snd_printd(fmt, args...) \ __snd_printk(1, __FILE__, __LINE__, fmt, ##args) +#define _snd_printd(level, fmt, args...) \ + __snd_printk(level, __FILE__, __LINE__, fmt, ##args) /** * snd_BUG - give a BUG warning message and stack trace @@ -383,6 +385,7 @@ void __snd_printk(unsigned int level, const char *file, int line, #else /* !CONFIG_SND_DEBUG */ #define snd_printd(fmt, args...) do { } while (0) +#define _snd_printd(level, fmt, args...) do { } while (0) #define snd_BUG() do { } while (0) static inline int __snd_bug_on(int cond) {