From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933500Ab1ESQSX (ORCPT ); Thu, 19 May 2011 12:18:23 -0400 Received: from cantor.suse.de ([195.135.220.2]:43338 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932732Ab1ESQSV (ORCPT ); Thu, 19 May 2011 12:18:21 -0400 Date: Thu, 19 May 2011 18:18:19 +0200 Message-ID: From: Takashi Iwai To: Madis Janson Cc: Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Enable Realtek ALC269 codec input layer beep In-Reply-To: References: User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 19 May 2011 17:32:19 +0300 (EEST), Madis Janson wrote: > > > This fixes the input layer beep not working on some EeePC 1000 models by > adding the subsystem id into whitelist. Otherwise the corresponding ALSA > mixer is not enabled and stays muted, resulting in no console beep. The change look good, but could you give your sign-off? See Documentation/SubmittingPatches section 12 "Sign your work" for details. Also, at the next time, please try to send the patch to the corresponding subsystem maintainers. scripts/get_maintainer.pl is your friend. thanks, Takashi > diff -u linux-2.6.39/sound/pci/hda/patch_realtek.c lohe-2.6.39/sound/pci/hda/patch_realtek.c > --- linux-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 07:06:34.000000000 +0300 > +++ lohe-2.6.39/sound/pci/hda/patch_realtek.c 2011-05-19 11:58:28.415669828 +0300 > @@ -5646,6 +5646,7 @@ > SND_PCI_QUIRK(0x1043, 0x829f, "ASUS", 1), > SND_PCI_QUIRK(0x1043, 0x83ce, "EeePC", 1), > SND_PCI_QUIRK(0x1043, 0x831a, "EeePC", 1), > + SND_PCI_QUIRK(0x1043, 0x834a, "EeePC", 1), > SND_PCI_QUIRK(0x8086, 0xd613, "Intel", 1), > {} > }; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >