From: Takashi Iwai <tiwai@suse.de>
To: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] i915: Skip wrong TV outputs on HP laptop
Date: Tue, 20 Apr 2010 14:50:54 +0200 [thread overview]
Message-ID: <s5htyr6jnip.wl%tiwai@suse.de> (raw)
A new HP laptop with GM45 seems detecting wrongly TV outputs
occasionally. Most of time it detects the TV output as disconnected,
but spontaneously it detects NTSC 480i although the laptop has no TV
output at all.
A simple (but ad hoc) fix is to add a DMI check as below.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/gpu/drm/i915/intel_tv.c | 17 +++++++++++++++++
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index 552ec11..e848a28 100644
--- a/drivers/gpu/drm/i915/intel_tv.c
+++ b/drivers/gpu/drm/i915/intel_tv.c
@@ -37,6 +37,7 @@
#include "intel_drv.h"
#include "i915_drm.h"
#include "i915_drv.h"
+#include <linux/dmi.h>
enum tv_margin {
TV_MARGIN_LEFT, TV_MARGIN_TOP,
@@ -1735,6 +1736,18 @@ static int tv_is_present_in_vbt(struct drm_device *dev)
return ret;
}
+static struct dmi_system_id intel_bad_tv[] = {
+ {
+ .ident = "HP Compaq 420",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HP 420"),
+ },
+ },
+
+ { } /* terminating entry */
+};
+
void
intel_tv_init(struct drm_device *dev)
{
@@ -1757,6 +1770,10 @@ intel_tv_init(struct drm_device *dev)
if (!dev_priv->int_tv_support)
return;
+ /* wrongly detected TV outputs */
+ if (dmi_check_system(intel_bad_tv))
+ return;
+
/*
* Sanity check the TV output by checking to see if the
* DAC register holds a value
--
1.7.0.4
next reply other threads:[~2010-04-20 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 12:50 Takashi Iwai [this message]
2010-04-20 17:13 ` Eric Anholt
2010-04-20 17:58 ` Takashi Iwai
2010-04-21 0:46 ` ykzhao
2010-04-21 5:47 ` Takashi Iwai
2010-04-21 14:03 ` Takashi Iwai
2010-04-21 8:01 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htyr6jnip.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=eric@anholt.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome