Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio

[Takashi Iwai <tiwai@suse.de>]

At Thu, 4 Mar 2010 19:37:52 +0800,
Wei Ni wrote:
> 
> Do you mean you will check in my patch first, and then I give you the
> additional patch for adding EXPORT_SYMBOL() in hda_eld.c?

Yes.  I need the integration tests first.
Meanwhile, prepare your patch on the top of your current patches.
Feel free to post it at any time.

After that, we can merge Fengguang's patch_hdmi.c change on that.


thanks,

Takashi


> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de] 
> Sent: Thursday, March 04, 2010 7:31 PM
> To: Wei Ni
> Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> 
> At Thu, 4 Mar 2010 19:09:29 +0800,
> Wei Ni wrote:
> > 
> > Hi, Takashi
> > I test my patch, it build successful when CONFIG_SND_HDA_*=y.
> > Could you give me your build error messages?
> 
> Sorry, it's CONFIG_SND_HDA*=m.  Then load two modules, so you'll have
> two identical objects in different modules.
> 
> OTOH, if it's no exported symbol, it might coexist.  Hmm.
> 
> If you get no errors with it, then it's fine as an intermediate state.
> Please give the additional patch on them for further fixes.
> 
> 
> thanks,
> 
> Takashi
> 
> > 
> > Thanks
> > Wei.
> > nvpublic
> > 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de] 
> > Sent: Thursday, March 04, 2010 6:57 PM
> > To: Wei Ni
> > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> > 
> > At Thu, 4 Mar 2010 18:46:59 +0800,
> > Wei Ni wrote:
> > > 
> > > Hi, Takashi
> > > I think we can submit my patch first,
> > 
> > But your patch breaks the build when CONFIG_SND_HDA_*=y.
> > So, it should be fixed in your patch.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> > > then generate another patch
> > > to add EXPORT_SYMBOL() in hda_eld.c, and change Makefile to remove
> > > hda_eld.o from snd-hda-codec-xxhdmi-objs.
> > > 
> > > Thanks
> > > Wei.
> > > nvpublic
> > > 
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai@suse.de] 
> > > Sent: Thursday, March 04, 2010 5:47 PM
> > > To: Wei Ni
> > > Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> > > Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> > > 
> > > At Thu, 4 Mar 2010 10:21:39 +0800,
> > > Wei Ni wrote:
> > > > 
> > > > Hi, Takashi
> > > > 1. Yes, it can works for all Nvidia controller.
> > > 
> > > OK.
> > > 
> > > > 2. The hda_eld.o doesn't export any symbols.
> > > > I tried to put hda_eld.o to snd-had-codec-*, and remove had_eldo.o
> > > > from snd-had-codec-intelhdmi-objs, but it will build error. It need
> > > > to modify hda_eld.c to export symbols, it will add many changes.
> > > 
> > > Yes, this is unavoidable.  Please add EXPORT_SYMBOL()'s
> > > appropriately.
> > > 
> > > We can reduce them again once after all HDMI stuff is merged into
> > > one.
> > > 
> > > 
> > > thanks,
> > > 
> > > Takashi
> > > 
> > 
>