From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1755940AbZLNKQ4@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755940AbZLNKQ4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Dec 2009 05:16:56 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755864AbZLNKQz
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 14 Dec 2009 05:16:55 -0500
Received: from cantor2.suse.de ([195.135.220.15]:35280 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755856AbZLNKQy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Dec 2009 05:16:54 -0500
Date: Mon, 14 Dec 2009 11:16:53 +0100
Message-ID: <s5htyvtlv1m.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 8/9] sound/isa/gus: Correct code taking the size of a pointer
In-Reply-To: <Pine.LNX.4.64.0912131242420.24267@ask.diku.dk>
References: <Pine.LNX.4.64.0912131242420.24267@ask.diku.dk>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Sun, 13 Dec 2009 12:42:56 +0100 (CET),
Julia Lawall wrote:
> 
> From: Julia Lawall <julia@diku.dk>
> 
> sizeof(share_id) is just the size of the pointer.  On the other hand,
> block->share_id is an array, so its size seems more appropriate.
> 
> A simplified version of the semantic patch that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression *x;
> expression f;
> type T;
> @@
> 
> *f(...,(T)x,...)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied now.  Thanks.


Takashi

> 
> ---
>  sound/isa/gus/gus_mem.c             |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/isa/gus/gus_mem.c b/sound/isa/gus/gus_mem.c
> index 661205c..af888a0 100644
> --- a/sound/isa/gus/gus_mem.c
> +++ b/sound/isa/gus/gus_mem.c
> @@ -127,7 +127,8 @@ static struct snd_gf1_mem_block *snd_gf1_mem_share(struct snd_gf1_mem * alloc,
>  	    !share_id[2] && !share_id[3])
>  		return NULL;
>  	for (block = alloc->first; block; block = block->next)
> -		if (!memcmp(share_id, block->share_id, sizeof(share_id)))
> +		if (!memcmp(share_id, block->share_id,
> +				sizeof(block->share_id)))
>  			return block;
>  	return NULL;
>  }
>