From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759996AbXLMLxJ (ORCPT ); Thu, 13 Dec 2007 06:53:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754269AbXLMLw5 (ORCPT ); Thu, 13 Dec 2007 06:52:57 -0500 Received: from ns.suse.de ([195.135.220.2]:46153 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753990AbXLMLw4 (ORCPT ); Thu, 13 Dec 2007 06:52:56 -0500 Date: Thu, 13 Dec 2007 11:44:02 +0100 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: lkml , perex@perex.cz Subject: Re: [PATCH] sound/ad1848: fix printk format In-Reply-To: <20071212204246.2d1fce7a.randy.dunlap@oracle.com> References: <20071029112010.1cecaefd.randy.dunlap@oracle.com> <20071212204246.2d1fce7a.randy.dunlap@oracle.com> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 12 Dec 2007 20:42:46 -0800, Randy Dunlap wrote: > > On Tue, 30 Oct 2007 12:05:28 +0100 Takashi Iwai wrote: > > > At Mon, 29 Oct 2007 11:20:10 -0700, > > Randy Dunlap wrote: > > > > > > From: Randy Dunlap > > > > > > Fix printk format warning: > > > > > > sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int' > > > > > > Signed-off-by: Randy Dunlap > > > > Thanks, but another fix was already in ALSA tree. > > > > Jaroslav, please prepare for push again? Some patches are really > > worth to be in 2.6.24. > > Hi, > This is still needed, over 1 month later.... Thanks for notice. It's in the alsa.git tree but it's slipped from the last push... Jaroslav, could you make it for push please? thanks, Takashi > > > > Takashi > > > > > --- > > > sound/isa/ad1848/ad1848_lib.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > --- linux-2624-rc1g4-v1.orig/sound/isa/ad1848/ad1848_lib.c > > > +++ linux-2624-rc1g4-v1/sound/isa/ad1848/ad1848_lib.c > > > @@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s > > > for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--) > > > udelay(100); > > > > > > - snd_printdd("(1) timeout = %d\n", timeout); > > > + snd_printdd("(1) timeout = %lu\n", timeout); > > > > > > #ifdef CONFIG_SND_DEBUG > > > if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT) > > > - > > > --- > ~Randy >