From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FEAEC433ED for ; Fri, 14 May 2021 07:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D71A8613C9 for ; Fri, 14 May 2021 07:47:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233100AbhENHsW (ORCPT ); Fri, 14 May 2021 03:48:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:59874 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbhENHsV (ORCPT ); Fri, 14 May 2021 03:48:21 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9ABC9B14A; Fri, 14 May 2021 07:47:09 +0000 (UTC) Date: Fri, 14 May 2021 09:47:09 +0200 Message-ID: From: Takashi Iwai To: YueHaibing Cc: , , , , Subject: Re: [PATCH -next] ALSA: gus: Replace unsafe strcpy() with strscpy() In-Reply-To: <20210514070507.16600-1-yuehaibing@huawei.com> References: <20210514070507.16600-1-yuehaibing@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 May 2021 09:05:07 +0200, YueHaibing wrote: > > Fix smatch warning: > sound/isa/gus/gus_main.c:396 snd_gus_check_version() error: > strcpy() 'card->longname' too large for 'card->shortname' (80 vs 32) > > Even if this is not a real bug since the longest length of card->longname > now is 31, replace strcpy() with strscpy() in order to avoid possible > future mistake. > > Signed-off-by: YueHaibing Applied, thanks. Takashi