From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40A9BFA372B for ; Thu, 17 Oct 2019 07:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2173720820 for ; Thu, 17 Oct 2019 07:19:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408069AbfJQHTv (ORCPT ); Thu, 17 Oct 2019 03:19:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:35048 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2408044AbfJQHTv (ORCPT ); Thu, 17 Oct 2019 03:19:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 17632ACE1; Thu, 17 Oct 2019 07:19:49 +0000 (UTC) Date: Thu, 17 Oct 2019 09:19:48 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: , Bjorn Helgaas , LKML , Linux PCI Subject: Re: [PATCH v4 2/2] ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a driver In-Reply-To: References: <20190925113255.25062-1-kai.heng.feng@canonical.com> <20190925113255.25062-2-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Oct 2019 20:49:56 +0200, Kai-Heng Feng wrote: > > Hi Takashi, > > > On Sep 25, 2019, at 19:32, Kai-Heng Feng wrote: > > > > Nvidia proprietary driver doesn't support runtime power management, so > > when a user only wants to use the integrated GPU, it's a common practice > > to let dGPU not to bind any driver, and let its upstream port to be > > runtime suspended. At the end of runtime suspension the port uses > > platform power management to disable power through _OFF method of power > > resource, which is listed by _PR3. > > > > After commit b516ea586d71 ("PCI: Enable NVIDIA HDA controllers"), when > > the dGPU comes with an HDA function, the HDA won't be suspended if the > > dGPU is unbound, so the power resource can't be turned off by its > > upstream port driver. > > > > Commit 37a3a98ef601 ("ALSA: hda - Enable runtime PM only for > > discrete GPU") only allows HDA to be runtime suspended once GPU is > > bound, to keep APU's HDA working. > > > > However, HDA on dGPU isn't that useful if dGPU is not bound to any > > driver. So let's relax the runtime suspend requirement for dGPU's HDA > > function, to disable the power source to save lots of power. > > > > BugLink: https://bugs.launchpad.net/bugs/1840835 > > Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") > > Signed-off-by: Kai-Heng Feng > > Do you still have any concern on this patch? > Please merge [v5 1/2] and this patch [v4 2/2] if you think it's good. Sorry for the late reply, as I've been off for a few weeks. Now I applied both patches for 5.4. Thanks! Takashi > > Thanks! > > Kai-Heng > > > --- > > v4: > > - Find upstream port, it's callee's responsibility now. > > v3: > > - Make changelog more clear. > > v2: > > - Change wording. > > - Rebase to Tiwai's branch. > > sound/pci/hda/hda_intel.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > > index 240f4ca76391..e63b871343e5 100644 > > --- a/sound/pci/hda/hda_intel.c > > +++ b/sound/pci/hda/hda_intel.c > > @@ -1280,11 +1280,17 @@ static void init_vga_switcheroo(struct azx *chip) > > { > > struct hda_intel *hda = container_of(chip, struct hda_intel, chip); > > struct pci_dev *p = get_bound_vga(chip->pci); > > + struct pci_dev *parent; > > if (p) { > > dev_info(chip->card->dev, > > "Handle vga_switcheroo audio client\n"); > > hda->use_vga_switcheroo = 1; > > - chip->bus.keep_power = 1; /* cleared in either gpu_bound op or codec probe */ > > + > > + /* cleared in either gpu_bound op or codec probe, or when its > > + * upstream port has _PR3 (i.e. dGPU). > > + */ > > + parent = pci_upstream_bridge(p); > > + chip->bus.keep_power = parent ? !pci_pr3_present(parent) : 1; > > chip->driver_caps |= AZX_DCAPS_PM_RUNTIME; > > pci_dev_put(p); > > } > > -- > > 2.17.1 > > > >