From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=0SVE=WF=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 42031C433FF
	for <linux-kernel@archiver.kernel.org>; Fri,  9 Aug 2019 08:23:46 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 166092166E
	for <linux-kernel@archiver.kernel.org>; Fri,  9 Aug 2019 08:23:46 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2405952AbfHIIXp (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 9 Aug 2019 04:23:45 -0400
Received: from mx2.suse.de ([195.135.220.15]:34436 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726014AbfHIIXo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Aug 2019 04:23:44 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id 4D506AF50;
        Fri,  9 Aug 2019 08:23:43 +0000 (UTC)
Date:   Fri, 09 Aug 2019 10:23:42 +0200
Message-ID: <s5hv9v6hhm9.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] Regression in next with codec unload and      snd_soc_component_get/put
In-Reply-To: <20190809074643.GB52127@atomide.com>
References: <20190809070003.GA52127@atomide.com>
        <s5hwofmhkbs.wl-tiwai@suse.de>
        <20190809074643.GB52127@atomide.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 09 Aug 2019 09:46:43 +0200,
Tony Lindgren wrote:
> 
> * Takashi Iwai <tiwai@suse.de> [190809 07:25]:
> > On Fri, 09 Aug 2019 09:00:03 +0200,
> > Tony Lindgren wrote:
> > > 
> > > Hi,
> > > 
> > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> > > snd_soc_component_get/put()") causes a regression where trying
> > > to rmmod a codec driver fails with module is in use error after
> > > rmmod of snd-soc-audio-graph-card for example.
> > > 
> > > Any ideas what goes wrong there?
> > 
> > There is an obvious typo: soc_cleanup_component() should call
> > snd_soc_component_module_put_when_remove() instead of *_close().
> 
> Making that change locally seems to fix it thanks.

... and it was already fixed in the later commit 0e36f36b04e7
"ASoC: soc-core: fix module_put() warning in soc_cleanup_component".


Takashi