From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2AD4ECE562 for ; Fri, 21 Sep 2018 09:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F09D20858 for ; Fri, 21 Sep 2018 09:23:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F09D20858 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389517AbeIUPLr (ORCPT ); Fri, 21 Sep 2018 11:11:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:44646 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388944AbeIUPLr (ORCPT ); Fri, 21 Sep 2018 11:11:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5E13EAF88; Fri, 21 Sep 2018 09:23:48 +0000 (UTC) Date: Fri, 21 Sep 2018 11:23:48 +0200 Message-ID: From: Takashi Iwai To: "Nick Simonov" Cc: , , , Subject: Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops In-Reply-To: <20180921092135.GA20633@kbp1-dhp-f54120> References: <20180921054514.GA11771@nick> <20180921092135.GA20633@kbp1-dhp-f54120> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Sep 2018 11:21:35 +0200, Nick Simonov wrote: > > On Fri, Sep 21, 2018 at 08:51:51AM +0200, Takashi Iwai wrote: > > On Fri, 21 Sep 2018 07:47:38 +0200, > > Nick Simonov wrote: > > > > > > snd_pcm_ops are not supposed to change. So mark the > > > non-const structs as const. Also, refine indentation > > > to increase readability. > > > > > > Signed-off-by: Nick Simonov > > > --- > > > Changes v2: > > > - Fix typo in commit description, ncrease to increase. > > > > Since I already merged your first version, please resubmit as an > > incremental patch. At best, check the latest linux-next or my > > sound.git tree for-next branch, and create a patch on its top. > > > > > > thanks, > > > > Takashi > > Sorry I want to clarify, there is no mistakes in the code itself > there is a typo in commit message. As I now there is no way to change > commit message without rebase after merge, so which is the proper way in > this case? leave it as is? Then let's leave as is. thanks, Takashi