From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751269AbdE3Iy0 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 04:54:26 -0400
Received: from mx2.suse.de ([195.135.220.15]:50845 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751007AbdE3IyY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 04:54:24 -0400
Date: Tue, 30 May 2017 10:54:22 +0200
Message-ID: <s5hvaoiencx.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Bhumika Goyal" <bhumirks@gmail.com>
Cc: <alsa-devel@alsa-project.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <clemens@ladisch.de>, <julia.lawall@lip6.fr>,
        <linuxppc-dev@lists.ozlabs.org>, <perex@perex.cz>,
        <johannes@sipsolutions.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const
In-Reply-To: <1495896375-30855-1-git-send-email-bhumirks@gmail.com>
References: <1495896375-30855-1-git-send-email-bhumirks@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 27 May 2017 16:46:15 +0200,
Bhumika Goyal wrote:
> 
> Declare snd_kcontrol_new structures as const as they are only passed an
> argument to the function snd_ctl_new1. This argument is of type const,
> so snd_kcontrol_new structures having this property can be made const.
> Done using Coccinelle:
> 
> @r disable optional_qualifier@
> identifier x;
> position p;
> @@
> static struct snd_kcontrol_new x@p={...};
> 
> @ok@
> identifier r.x;
> position p;
> @@
> snd_ctl_new1(&x@p,...)
> 
> @bad@
> position p != {r.p,ok.p};
> identifier r.x;
> @@
> x@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r.x;
> @@
> +const
> struct snd_kcontrol_new x;
> 
> Cross compiled these files:
> sound/aoa/codecs/tas.c - powerpc
> sound/mips/{hal2.c/sgio2audio.c} - mips
> sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc
> sound/soc/sh/siu_dai.c - sh
> Could not find an architecture to compile sound/sh/aica.c.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied now, as it looks safe enough.  But I prefer splitting to
individual patches, so please try to do that at the next time.


thanks,

Takashi