From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161350AbdDVGyQ (ORCPT ); Sat, 22 Apr 2017 02:54:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:35828 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1041966AbdDVGyN (ORCPT ); Sat, 22 Apr 2017 02:54:13 -0400 Date: Sat, 22 Apr 2017 08:54:11 +0200 Message-ID: From: Takashi Iwai To: Julia Lawall Cc: Simon Ho , alsa-devel@alsa-project.org, Liam Girdwood , Jaroslav Kysela , Mark Brown , linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: Re: [PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd) In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 22 Apr 2017 00:14:57 +0200, Julia Lawall wrote: > > I don't think the patch is correct, so I haven't bothered signing off on > it. Probably the & is not correct in the IS_ERR call? Yes, IS_ERR() was called with the wrong argument. I fixed it now. Note that it's no branch to be merged to upstream yet, it's just a testing for the previously submitted patchset. Simon, my latest version is found in topic/soc-cx2072x branch in sound git tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git Please check that before the next submission. thanks, Takashi > > julia > > ---------- Forwarded message ---------- > Date: Sat, 22 Apr 2017 06:09:26 +0800 > From: kbuild test robot > To: kbuild@01.org > Cc: Julia Lawall > Subject: [PATCH] ASoC: fix odd_ptr_err.cocci warnings > > PTR_ERR should access the value just tested by IS_ERR > > Semantic patch information: > There can be false positives in the patch case, where it is the call to > IS_ERR that is wrong. > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > CC: Simon Ho > Signed-off-by: Fengguang Wu > --- > > Please take the patch only if it's a positive warning. Thanks! > > cx2072x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/sound/soc/codecs/cx2072x.c > +++ b/sound/soc/codecs/cx2072x.c > @@ -2183,7 +2183,7 @@ static int cx2072x_i2c_probe(struct i2c_ > &cx2072x_regmap); > > if (IS_ERR(&cx2072x->regmap)) { > - ret = PTR_ERR(cx2072x->regmap); > + ret = PTR_ERR(&cx2072x->regmap); > dev_err(&i2c->dev, "Failed to init regmap: %d\n", ret); > return ret; > } >