From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960AbbAKPxY (ORCPT ); Sun, 11 Jan 2015 10:53:24 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35186 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbbAKPxV (ORCPT ); Sun, 11 Jan 2015 10:53:21 -0500 Date: Sun, 11 Jan 2015 16:53:20 +0100 Message-ID: From: Takashi Iwai To: Rickard Strandqvist Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: lola: lola_mixer: Remove some unused functions In-Reply-To: <1420986242-18502-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1420986242-18502-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 11 Jan 2015 15:24:02 +0100, Rickard Strandqvist wrote: > > Removes some functions that are not used anywhere: > lola_restore_mixer() lola_save_mixer() These are needed (yet-to-be-implemented) suspend/resume for this driver. Takashi > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > sound/pci/lola/lola.h | 2 -- > sound/pci/lola/lola_mixer.c | 43 ------------------------------------------- > 2 files changed, 45 deletions(-) > > diff --git a/sound/pci/lola/lola.h b/sound/pci/lola/lola.h > index f0b1000..9125916 100644 > --- a/sound/pci/lola/lola.h > +++ b/sound/pci/lola/lola.h > @@ -513,8 +513,6 @@ int lola_init_mixer_widget(struct lola *chip, int nid); > void lola_free_mixer(struct lola *chip); > int lola_create_mixer(struct lola *chip); > int lola_setup_all_analog_gains(struct lola *chip, int dir, bool mute); > -void lola_save_mixer(struct lola *chip); > -void lola_restore_mixer(struct lola *chip); > int lola_set_src_config(struct lola *chip, unsigned int src_mask, bool update); > > /* proc */ > diff --git a/sound/pci/lola/lola_mixer.c b/sound/pci/lola/lola_mixer.c > index 782f4d8..47ac93a 100644 > --- a/sound/pci/lola/lola_mixer.c > +++ b/sound/pci/lola/lola_mixer.c > @@ -348,49 +348,6 @@ int lola_setup_all_analog_gains(struct lola *chip, int dir, bool mute) > return lola_codec_flush(chip); > } > > -void lola_save_mixer(struct lola *chip) > -{ > - /* mute analog output */ > - if (chip->mixer.array_saved) { > - /* store contents of mixer array */ > - memcpy_fromio(chip->mixer.array_saved, chip->mixer.array, > - sizeof(*chip->mixer.array)); > - } > - lola_setup_all_analog_gains(chip, PLAY, true); /* output mute */ > -} > - > -void lola_restore_mixer(struct lola *chip) > -{ > - int i; > - > - /*lola_reset_setups(chip);*/ > - if (chip->mixer.array_saved) { > - /* restore contents of mixer array */ > - memcpy_toio(chip->mixer.array, chip->mixer.array_saved, > - sizeof(*chip->mixer.array)); > - /* inform micro-controller about all restored values > - * and ignore return values > - */ > - for (i = 0; i < chip->mixer.src_phys_ins; i++) > - lola_codec_write(chip, chip->mixer.nid, > - LOLA_VERB_SET_SOURCE_GAIN, > - i, 0); > - for (i = 0; i < chip->mixer.src_stream_outs; i++) > - lola_codec_write(chip, chip->mixer.nid, > - LOLA_VERB_SET_SOURCE_GAIN, > - chip->mixer.src_stream_out_ofs + i, 0); > - for (i = 0; i < chip->mixer.dest_stream_ins; i++) > - lola_codec_write(chip, chip->mixer.nid, > - LOLA_VERB_SET_DESTINATION_GAIN, > - i, 0); > - for (i = 0; i < chip->mixer.dest_phys_outs; i++) > - lola_codec_write(chip, chip->mixer.nid, > - LOLA_VERB_SET_DESTINATION_GAIN, > - chip->mixer.dest_phys_out_ofs + i, 0); > - lola_codec_flush(chip); > - } > -} > - > /* > */ > > -- > 1.7.10.4 >