From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754137Ab3KKPKO (ORCPT ); Mon, 11 Nov 2013 10:10:14 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38778 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753801Ab3KKPKJ (ORCPT ); Mon, 11 Nov 2013 10:10:09 -0500 Date: Mon, 11 Nov 2013 16:10:06 +0100 Message-ID: From: Takashi Iwai To: Ming Lei Cc: Linux Kernel Mailing List , Prarit Bhargava , Greg Kroah-Hartman , x86@kernel.org, amd64-microcode@amd64.org Subject: Re: [PATCH 1/2] firmware: Introduce request_firmware_direct() In-Reply-To: References: <1383652626-30437-1-git-send-email-tiwai@suse.de> <1383652626-30437-2-git-send-email-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 11 Nov 2013 15:44:38 +0800, Ming Lei wrote: > > Hi Takashi, > > On Tue, Nov 5, 2013 at 7:57 PM, Takashi Iwai wrote: > > When CONFIG_FW_LOADER_USER_HELPER is set, request_firmware() falls > > back to the usermode helper for loading via udev when the direct > > loading fails. But the recent udev takes way too long timeout (60 > > seconds) for non-existing firmware. This is unacceptable for the > > drivers like microcode loader where they load firmwares optionally, > > i.e. it's no error even if no requested file exists. > > > > This patch provides a new helper function, request_firmware_direct(). > > It behaves as same as request_firmware() except for that it doesn't > > fall back to usermode helper but returns an error immediately if the > > f/w can't be loaded directly in kernel. > > > > Without CONFIG_FW_LOADER_USER_HELPER=y, request_firmware_direct() is > > just an alias of request_firmware(), due to obvious reason. > > > > Tested-by: Prarit Bhargava > > Signed-off-by: Takashi Iwai > > The patch is fine, except it should be against -next, so you can feel > free to add my Acked-by in your next submission. OK, I'm going to resubmit the patch series based on next. BTW, looking at linux-next code, I found another issue in the relevant place; the fallback warning is shown no matter whether CONFIG_FIRMWAMRE_USERMODE_HELPER is set or not. I'll put the fix into the next series, too. thanks, Takashi