From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754742Ab3A2I1A (ORCPT ); Tue, 29 Jan 2013 03:27:00 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42919 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754494Ab3A2I06 (ORCPT ); Tue, 29 Jan 2013 03:26:58 -0500 Date: Tue, 29 Jan 2013 09:26:55 +0100 Message-ID: From: Takashi Iwai To: David Airlie Cc: Stefan Dirsch , Bernhard Wiedemann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/cirrus: Correct register values for 16bpp In-Reply-To: <1359130915-30082-1-git-send-email-tiwai@suse.de> References: <1359130915-30082-1-git-send-email-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, any chance to take a look at this problem? thanks, Takashi At Fri, 25 Jan 2013 17:21:54 +0100, Takashi Iwai wrote: > > When the mode is set with 16bpp on QEMU, the output gets totally > broken. The culprit is the bogus register values set for 16bpp, > which was likely copied from from a wrong place. > > Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=799216 > > Cc: > Signed-off-by: Takashi Iwai > --- > drivers/gpu/drm/cirrus/cirrus_mode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c > index 60685b2..379a47e 100644 > --- a/drivers/gpu/drm/cirrus/cirrus_mode.c > +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c > @@ -273,8 +273,8 @@ static int cirrus_crtc_mode_set(struct drm_crtc *crtc, > sr07 |= 0x11; > break; > case 16: > - sr07 |= 0xc1; > - hdr = 0xc0; > + sr07 |= 0x17; > + hdr = 0xc1; > break; > case 24: > sr07 |= 0x15; > -- > 1.8.1.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >