mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Vincent Blut <vincent.debian@free.fr>
Cc: Maurizio Avogadro <mavoga@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [3.6.9 -> 3.7.1 regression] sound: snd_hda_intel codec probing issue?
Date: Wed, 09 Jan 2013 11:00:26 +0100	[thread overview]
Message-ID: <s5hvcb6n0at.wl%tiwai@suse.de> (raw)
In-Reply-To: <1357676721.3776.3.camel@lamella>

At Tue, 08 Jan 2013 21:25:21 +0100,
Vincent Blut wrote:
> 
> Le mardi 08 janvier 2013 à 13:56 +0100, Takashi Iwai a écrit :
> > At Tue, 08 Jan 2013 13:28:55 +0100,
> > From: Takashi Iwai <tiwai@suse.de>
> > Subject: [PATCH] ALSA: hda - Disable runtime D3 for Intel CPT & co
> > 
> > We've got a few bug reports that the runtime D3 results in the dead
> > HD-audio controller.  It seems that the problem is in a deeper level
> > than the sound driver itself, so as a temporal solution, disable the
> > feature for these controllers again.
> > 
> > Reported-by: Vincent Blut <vincent.debian@free.fr>
> > Reported-by: Maurizio Avogadro <mavoga@gmail.com>
> > Cc: <stable@vger.kernel.org> [v3.7]
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >  sound/pci/hda/hda_intel.c | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> > 
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index cca8727..0b6aeba 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -573,9 +573,12 @@ enum {
> >  #define AZX_DCAPS_PM_RUNTIME	(1 << 26)	/* runtime PM support */
> >  
> >  /* quirks for Intel PCH */
> > -#define AZX_DCAPS_INTEL_PCH \
> > +#define AZX_DCAPS_INTEL_PCH_NOPM \
> >  	(AZX_DCAPS_SCH_SNOOP | AZX_DCAPS_BUFSIZE | \
> > -	 AZX_DCAPS_COUNT_LPIB_DELAY | AZX_DCAPS_PM_RUNTIME)
> > +	 AZX_DCAPS_COUNT_LPIB_DELAY)
> > +
> > +#define AZX_DCAPS_INTEL_PCH \
> > +	(AZX_DCAPS_INTEL_PCH_NOPM | AZX_DCAPS_PM_RUNTIME)
> >  
> >  /* quirks for ATI SB / AMD Hudson */
> >  #define AZX_DCAPS_PRESET_ATI_SB \
> > @@ -3586,13 +3589,13 @@ static void azx_remove(struct pci_dev *pci)
> >  static DEFINE_PCI_DEVICE_TABLE(azx_ids) = {
> >  	/* CPT */
> >  	{ PCI_DEVICE(0x8086, 0x1c20),
> > -	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
> > +	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
> >  	/* PBG */
> >  	{ PCI_DEVICE(0x8086, 0x1d20),
> > -	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
> > +	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
> >  	/* Panther Point */
> >  	{ PCI_DEVICE(0x8086, 0x1e20),
> > -	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
> > +	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
> >  	/* Lynx Point */
> >  	{ PCI_DEVICE(0x8086, 0x8c20),
> >  	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
> 
> Well, my sound controller behaves nicely with the above quirk.
> 
> Tested-by: Vincent Blut <vincent.debian@free.fr>

OK, I queued the patch now.


thanks,

Takashi

  reply	other threads:[~2013-01-09 10:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-28 14:25 Vincent Blut
2013-01-03  9:19 ` Takashi Iwai
2013-01-03 13:39   ` Vincent Blut
2013-01-05 21:24   ` Vincent Blut
2013-01-07  8:32     ` Takashi Iwai
2013-01-08 12:28       ` Vincent Blut
2013-01-08 12:56         ` Takashi Iwai
2013-01-08 14:13           ` Vincent Blut
2013-01-08 14:32           ` [alsa-devel] " David Henningsson
2013-01-08 14:39             ` Takashi Iwai
2013-01-08 20:25           ` Vincent Blut
2013-01-09 10:00             ` Takashi Iwai [this message]
2013-01-08  0:04   ` Maurizio Avogadro
     [not found]   ` <50EBD772.3090008@gmail.com>
     [not found]     ` <s5htxqsyt7g.wl%tiwai@suse.de>
2013-01-08  8:55       ` Maurizio Avogadro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hvcb6n0at.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mavoga@gmail.com \
    --cc=vincent.debian@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®