From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755330Ab1GGJAx (ORCPT ); Thu, 7 Jul 2011 05:00:53 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42963 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754123Ab1GGJAw (ORCPT ); Thu, 7 Jul 2011 05:00:52 -0400 Date: Thu, 07 Jul 2011 11:00:47 +0200 Message-ID: From: Takashi Iwai To: "Toshiharu Okada" Cc: , , , , , , , Subject: Re: [PATCH] Add SoundCard driver for OKI SEMICONDUCTOR ML7213 IOH In-Reply-To: <34CF59A8D33E40B6822498A23CD554E8@hacdom.okisemi.com> References: <1309948067-9333-1-git-send-email-toshiharu-linux@dsn.okisemi.com> <34CF59A8D33E40B6822498A23CD554E8@hacdom.okisemi.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 7 Jul 2011 16:54:18 +0900, Toshiharu Okada wrote: > > Date: Wed, 06 Jul 2011 13:06:15 +0200 > From: Takashi Iwai > > > >I just took a quick glance over the code, and wonder whether this kind > >of driver would fit better with ASoC framework. > >Have you considered the implementation on ASoC? > > Thank you for your comment. > > I referred to the following files and implemented this driver. > > http://www.mirrorservice.org/sites/ftp.sourceforge.net/pub/sourceforge/s/project/st/sta2x11/2.6.33/20100910/20100910-alpha-src.zip > sound/drivers/sta2x11i2s.c > > Therefore, I am not considering about ASoC. > Do I need to fit this driver to an ASoC framework for an upstream? Yes, I guess this would be a better choice in your case. Takashi