From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755481Ab1FPTAS (ORCPT ); Thu, 16 Jun 2011 15:00:18 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55177 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754559Ab1FPTAP (ORCPT ); Thu, 16 Jun 2011 15:00:15 -0400 Date: Thu, 16 Jun 2011 21:00:13 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: lkml , alsa-devel@alsa-project.org Subject: Re: [PATCH] sound: fix lola section mismatch warnings In-Reply-To: <20110616115646.7526c8af.randy.dunlap@oracle.com> References: <20110616115646.7526c8af.randy.dunlap@oracle.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 16 Jun 2011 11:56:46 -0700, Randy Dunlap wrote: > > From: Randy Dunlap > > Fix section mismatch warnings in lola sound driver: > > WARNING: sound/pci/lola/snd-lola.o(.text+0xda4): Section mismatch in reference from the function lola_parse_tree() to the function .devinit.text:lola_init_pcm() > The function lola_parse_tree() references > the function __devinit lola_init_pcm(). > This is often because lola_parse_tree lacks a __devinit > annotation or the annotation of lola_init_pcm is wrong. > > WARNING: sound/pci/lola/snd-lola.o(.text+0xdf5): Section mismatch in reference from the function lola_parse_tree() to the function .devinit.text:lola_init_pins() > The function lola_parse_tree() references > the function __devinit lola_init_pins(). > This is often because lola_parse_tree lacks a __devinit > annotation or the annotation of lola_init_pins is wrong. > > WARNING: sound/pci/lola/snd-lola.o(.text+0xe52): Section mismatch in reference from the function lola_parse_tree() to the function .devinit.text:lola_init_clock_widget() > The function lola_parse_tree() references > the function __devinit lola_init_clock_widget(). > This is often because lola_parse_tree lacks a __devinit > annotation or the annotation of lola_init_clock_widget is wrong. > > Signed-off-by: Randy Dunlap > Cc: Takashi Iwai Thanks, but the same is already in sound git tree. Takashi > --- > sound/pci/lola/lola.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- lnx-30-rc3.orig/sound/pci/lola/lola.c > +++ lnx-30-rc3/sound/pci/lola/lola.c > @@ -445,7 +445,7 @@ static void lola_reset_setups(struct lol > lola_setup_all_analog_gains(chip, PLAY, false); /* output, update */ > } > > -static int lola_parse_tree(struct lola *chip) > +static int __devinit lola_parse_tree(struct lola *chip) > { > unsigned int val; > int nid, err; >