From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1755499AbZFAIps@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755499AbZFAIps (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Jun 2009 04:45:48 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751643AbZFAIpk
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 1 Jun 2009 04:45:40 -0400
Received: from cantor.suse.de ([195.135.220.2]:39579 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751970AbZFAIpj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Jun 2009 04:45:39 -0400
Date: Mon, 01 Jun 2009 10:45:38 +0200
Message-ID: <s5hvdngfikt.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Wei Ni" <wni@nvidia.com>
Cc: alsa-devel@alsa-project.org, Marek Vasut <marek.vasut@gmail.com>,
       Peer Chen <pchen@nvidia.com>,
       linux-kernel <linux-kernel@vger.kernel.org>,
       Pavel Hofman <pavel.hofman@insite.cz>, akpm <akpm@linux-foundation.org>
Subject: Re: [alsa-devel]  [PATCH] Support NVIDIA 8 channel HDMI audio
In-Reply-To: <200906010707.30788.marek.vasut@gmail.com>
References: <15F501D1A78BD343BE8F4D8DB854566B058A63E9@hkemmail01.nvidia.com>
	<200906010707.30788.marek.vasut@gmail.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 1 Jun 2009 07:07:30 +0200,
Marek Vasut wrote:
> 
> On Monday 01 of June 2009 04:51:16 Wei Ni wrote:
> > Hi, Takashi
> > I'm a Nvidia engineer, we wish to support 8 channel HDMI audio for
> > MCP78/7A.
> >
> > I attached the patch file, it based on the latest sound git tree,
> > please check it.
> >
> 
> Hi,
> can you please run scripts/checkpatch.pl on the patches you submit? I'd help a 
> lot, thanks.
> 
> btw. here's the output (shortened):
> 
> total: 47 errors, 15 warnings, 349 lines checked
> 
> 0001-Support-NVIDIA-8-channel-HDMI-audio.patch has style problems, please 
> review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.

Yep, that'll be helpful.
The changes there look almost fine after a quick glance, so please just
fix cosmetic coding issues and repost.


thanks,

Takashi