From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753465AbXGIIhX (ORCPT ); Mon, 9 Jul 2007 04:37:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751315AbXGIIhL (ORCPT ); Mon, 9 Jul 2007 04:37:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:36042 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbXGIIhK (ORCPT ); Mon, 9 Jul 2007 04:37:10 -0400 Date: Mon, 09 Jul 2007 10:37:08 +0200 Message-ID: From: Takashi Iwai To: "Adrian McMenamin" Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ALSA AICA sound on SEGA Dreamcast - fix behaviour in poor resource conditions In-Reply-To: <92a12cdb0707061342u43273851ufa7e99b7e96da606@mail.gmail.com> References: <92a12cdb0707051507r7ab1516blb7ea755d89c25efa@mail.gmail.com> <92a12cdb0707060246p407f19depe16c59ac43eb0d96@mail.gmail.com> <92a12cdb0707060309x6fe997nc3112d5545d73ef5@mail.gmail.com> <92a12cdb0707061342u43273851ufa7e99b7e96da606@mail.gmail.com> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 6 Jul 2007 21:42:27 +0100, Adrian McMenamin wrote: > > On 06/07/07, Adrian McMenamin wrote: > > On 06/07/07, Takashi Iwai wrote: > > > I guess you shoud call del_timer() there at least. Otherwise the > > > timer handler (aica_period_elapsed()) might be called even if the > > > stream is not really running. > > > > > > > Fair enough. I'll fix that and repost later. > > > > > > Attached is a new patch, tidied with indent and with > SNDRV_PCM_TRIGGER_STOP being used. > > Submitted by: Adrian McMenamin > Signed-off by: Adrian McMenamin Thanks, committed to ALSA tree now. Takashi