From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750939AbWGKKRS (ORCPT ); Tue, 11 Jul 2006 06:17:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750937AbWGKKRS (ORCPT ); Tue, 11 Jul 2006 06:17:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:35987 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1750925AbWGKKRR (ORCPT ); Tue, 11 Jul 2006 06:17:17 -0400 Date: Tue, 11 Jul 2006 12:17:11 +0200 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] [2.6 patch] make sound/isa/gus/gusextreme.c:devices static In-Reply-To: <20060710220236.GI13938@stusta.de> References: <20060710220236.GI13938@stusta.de> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 11 Jul 2006 00:02:36 +0200, Adrian Bunk wrote: > > "devices" is not a good name for a global variable. > > Thankfully, it can become static. > > Signed-off-by: Adrian Bunk Applied to ALSA tree now. Thanks. Takashi > > --- linux-2.6.18-rc1-mm1-full/sound/isa/gus/gusextreme.c.old 2006-07-10 01:15:13.000000000 +0200 > +++ linux-2.6.18-rc1-mm1-full/sound/isa/gus/gusextreme.c 2006-07-10 01:15:20.000000000 +0200 > @@ -87,7 +87,7 @@ > module_param_array(pcm_channels, int, NULL, 0444); > MODULE_PARM_DESC(pcm_channels, "Reserved PCM channels for GUS Extreme driver."); > > -struct platform_device *devices[SNDRV_CARDS]; > +static struct platform_device *devices[SNDRV_CARDS]; > > > #define PFX "gusextreme: " > > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/alsa-devel >