From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 456B7C35273 for ; Wed, 6 Apr 2022 01:10:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1840572AbiDFBLD (ORCPT ); Tue, 5 Apr 2022 21:11:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1457200AbiDEQCz (ORCPT ); Tue, 5 Apr 2022 12:02:55 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD3832F3A8 for ; Tue, 5 Apr 2022 08:32:50 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 015831F37D; Tue, 5 Apr 2022 15:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649172769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o1T9kHw4YkgzAzeHJb8LqxvUd4Kx7c2662b3fqCcBDI=; b=HJrwxsR6IrepVQxZuwAYKA5i47gop3GBVCxUmmL/En11Ginj0aIAx2mipjasfKc0OcWG+q 5MQUPN1Iq1/0eHJ81qeeEw7Rwae9RhuCmFp2XbSVSs28Y76L8UjIF0Pr1XTm7tzikjpbUj wigD95WPiLM6HiTx/3zDSRkeVGOh15E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649172769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o1T9kHw4YkgzAzeHJb8LqxvUd4Kx7c2662b3fqCcBDI=; b=NKx+vh5j2MgY3SkmqQoj7qVrFVUZsnMrY4IRPYwtRSEajM4wEJ82VbxDDRa6Fq6Kd1a2JY 59YLb8kPdL4mLkCQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id E3E12A3B82; Tue, 5 Apr 2022 15:32:48 +0000 (UTC) Date: Tue, 05 Apr 2022 17:32:48 +0200 Message-ID: From: Takashi Iwai To: Borislav Petkov Cc: LKML , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH 02/11] ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant In-Reply-To: <20220405151517.29753-3-bp@alien8.de> References: <20220405151517.29753-1-bp@alien8.de> <20220405151517.29753-3-bp@alien8.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 05 Apr 2022 17:15:08 +0200, Borislav Petkov wrote: > > From: Borislav Petkov > > Fix: > > sound/usb/midi.c: In function ‘snd_usbmidi_out_endpoint_create’: > sound/usb/midi.c:1389:2: error: case label does not reduce to an integer constant > case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */ > ^~~~ > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory > details as to why it triggers with older gccs only. > > Signed-off-by: Borislav Petkov > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: alsa-devel@alsa-project.org > --- > sound/usb/usbaudio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/usbaudio.h b/sound/usb/usbaudio.h > index 167834133b9b..2b3dd55e8ee0 100644 > --- a/sound/usb/usbaudio.h > +++ b/sound/usb/usbaudio.h > @@ -8,7 +8,7 @@ > */ > > /* handling of USB vendor/product ID pairs as 32-bit numbers */ > -#define USB_ID(vendor, product) (((vendor) << 16) | (product)) > +#define USB_ID(vendor, product) ((((unsigned int)vendor) << 16) | (product)) Parentheses are needed around vendor (as usual for a macro). Could you resubmit with it? Thanks. Takashi