From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B0EDC433FE for ; Wed, 30 Mar 2022 08:18:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244304AbiC3IUY (ORCPT ); Wed, 30 Mar 2022 04:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244257AbiC3ITx (ORCPT ); Wed, 30 Mar 2022 04:19:53 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E1202F024 for ; Wed, 30 Mar 2022 01:18:01 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 100A61F7AD; Wed, 30 Mar 2022 08:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1648628280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/QNvaPOjH0w65NzenY+F0uSGoHt4n2nfiu+E5ad0lj4=; b=KAEOVn9GTVtqLByBcuNrce4yh4CgyY63d21mWqqh31uj3RiYMUT0b3QuClbUIYsmTTVmw+ t8yiXPwNCXRXcPmZtd58V/32vk/mnf6UkQsSbIJUBpKa3fAJfnqyGzRHI62Pmw+tq3/leD Csv9tLs2bLaorO+I/BjfdCmCjnw60lo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1648628280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/QNvaPOjH0w65NzenY+F0uSGoHt4n2nfiu+E5ad0lj4=; b=W82zOpjzpo7MHfhww59XLeWVgqWa4dVgU/S+VrEKxcWaCx3O+XQ0pxjOfV1mQr1/d+x60Z r7aa5+GluzEMdFAg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 61477A3B8A; Wed, 30 Mar 2022 08:17:59 +0000 (UTC) Date: Wed, 30 Mar 2022 10:17:59 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: tiwai@suse.com, kernel test robot , Dan Carpenter , Jaroslav Kysela , Jeremy Szu , Werner Sembach , Hui Wang , Lucas Tanure , Cameron Berkenpas , Kailang Yang , Sami Loone , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020 In-Reply-To: <20220330061335.1015533-1-kai.heng.feng@canonical.com> References: <20220330061335.1015533-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Mar 2022 08:13:33 +0200, Kai-Heng Feng wrote: > > Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording > issue") is to solve recording issue met on AL236, by matching codec > variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256. > > This match can be too broad and Mi Notebook Pro 2020 is broken by the > patch. > > Instead, use codec ID to be narrow down the scope, in order to make > ALC256 unaffected. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484 > Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Kai-Heng Feng > --- > v2: > Fix wrong comparison, || -> && Thanks, applied now. Takashi