From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B66C433E0 for ; Sat, 23 Jan 2021 12:43:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C03B622C7B for ; Sat, 23 Jan 2021 12:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726516AbhAWMms (ORCPT ); Sat, 23 Jan 2021 07:42:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:60520 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726024AbhAWMmo (ORCPT ); Sat, 23 Jan 2021 07:42:44 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8A488AC4F; Sat, 23 Jan 2021 12:42:03 +0000 (UTC) Date: Sat, 23 Jan 2021 13:42:03 +0100 Message-ID: From: Takashi Iwai To: Jamie Heilman Cc: linux-kernel@vger.kernel.org Subject: Re: bisected regression in v5.11-rc1 snd-usb-audio In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Jan 2021 12:08:02 +0100, Jamie Heilman wrote: > > > If the problem is still seen with the very latest Linus tree and the > > previous patch, please enable the dyndbg, e.g. pass dydbg=+p option to > > snd-usb-audio module, i.e. reload like > > modprobe snd-usb-audio dydbg=+p > > or boot with > > snd_usb_audio.dyndbg=+p > > boot option, retest, and give the kernel messages. > > OK, updated to 5.11.0-rc4-00202-gfe75a21824e7, repatched & rebuilt with: > CONFIG_SND_DEBUG=y > CONFIG_SND_CTL_VALIDATION=y > CONFIG_DYNAMIC_DEBUG=y > CONFIG_DYNAMIC_DEBUG_CORE=y > > and added dyndbg=+p to my snd-usb-audio options, dmesg after an > attempted aplay execution is attached. (snip) > [ 108.941521] WARNING: CPU: 0 PID: 2776 at sound/core/pcm_lib.c:1148 snd_pcm_hw_rule_add+0xd3/0x160 [snd_pcm] OK, this must be the culprit of the weird behavior. I totally overlooked that the max dependencies are three because of the terminator. Could you try the patch below in addition? thanks, Takashi --- a/include/sound/pcm.h +++ b/include/sound/pcm.h @@ -229,7 +229,7 @@ typedef int (*snd_pcm_hw_rule_func_t)(struct snd_pcm_hw_params *params, struct snd_pcm_hw_rule { unsigned int cond; int var; - int deps[4]; + int deps[5]; snd_pcm_hw_rule_func_t func; void *private;