From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A8BC4361B for ; Fri, 11 Dec 2020 23:31:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCF352333C for ; Fri, 11 Dec 2020 23:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405389AbgLKWmV (ORCPT ); Fri, 11 Dec 2020 17:42:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:38644 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393966AbgLKWld (ORCPT ); Fri, 11 Dec 2020 17:41:33 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D8EF5AD63; Fri, 11 Dec 2020 22:40:51 +0000 (UTC) Date: Fri, 11 Dec 2020 23:40:51 +0100 Message-ID: From: Takashi Iwai To: Pavel Machek Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 4.19 15/39] ALSA: hda/generic: Add option to enforce preferred_dacs pairs In-Reply-To: <20201211223822.GB18452@amd> References: <20201210142602.272595094@linuxfoundation.org> <20201210142603.037114540@linuxfoundation.org> <20201211083621.GA9395@duo.ucw.cz> <20201211223822.GB18452@amd> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Dec 2020 23:38:22 +0100, Pavel Machek wrote: > > Hi! > > > > > From: Takashi Iwai > > > > > > > > commit 242d990c158d5b1dabd166516e21992baef5f26a upstream. > > > > > > > > The generic parser accepts the preferred_dacs[] pairs as a hint for > > > > assigning a DAC to each pin, but this hint doesn't work always > > > > effectively. Currently it's merely a secondary choice after the trial > > > > with the path index failed. This made sometimes it difficult to > > > > assign DACs without mimicking the connection list and/or the badness > > > > table. > > > > > > > > This patch adds a new flag, obey_preferred_dacs, that changes the > > > > behavior of the parser. As its name stands, the parser obeys the > > > > > > Option added is never used as variable is never set. We don't need > > > this in 4.19. > > > > Right, it seems that the succeeding fix is queued only for 5.4 and > > 5.9. > > > > OTOH, this change will help if another quirk is added in near future, > > and it's pretty safe to apply, so I think it's worth to keep it. > > I agree that this is safe to apply and makes sense if we get another > quirk soon. OTOH it is trivial to backport if it is needed. It's trivial to backport, but it's not trivial to let stable maintainers to inform beforehand if the next patch has CC-to-stable tag. Keeping this makes the backport easier, that's the point. thanks, Takashi