From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96B2C3A59E for ; Mon, 2 Sep 2019 11:41:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 864AC2173E for ; Mon, 2 Sep 2019 11:41:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731047AbfIBLlH (ORCPT ); Mon, 2 Sep 2019 07:41:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:48170 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727951AbfIBLlH (ORCPT ); Mon, 2 Sep 2019 07:41:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2258FAEEC; Mon, 2 Sep 2019 11:41:05 +0000 (UTC) Date: Mon, 02 Sep 2019 13:41:04 +0200 Message-ID: From: Takashi Iwai To: "Jian-Hong Pan" Cc: "Jaroslav Kysela" , , , Subject: Re: [PATCH] ALSA: hda/realtek - Enable internal speaker & headset mic of ASUS UX431FL In-Reply-To: <20190902100054.6941-1-jian-hong@endlessm.com> References: <20190902100054.6941-1-jian-hong@endlessm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Sep 2019 12:00:56 +0200, Jian-Hong Pan wrote: > > Original pin node values of ASUS UX431FL with ALC294: > > 0x12 0xb7a60140 > 0x13 0x40000000 > 0x14 0x90170110 > 0x15 0x411111f0 > 0x16 0x411111f0 > 0x17 0x90170111 > 0x18 0x411111f0 > 0x19 0x411111f0 > 0x1a 0x411111f0 > 0x1b 0x411111f0 > 0x1d 0x4066852d > 0x1e 0x411111f0 > 0x1f 0x411111f0 > 0x21 0x04211020 > > 1. Has duplicated internal speakers (0x14 & 0x17) which makes the output > route become confused. So, the output volume cannot be changed by > setting. > 2. Misses the headset mic pin node. > > This patch disables the confusing speaker (NID 0x14) and enables the > headset mic (NID 0x19). Is 0x14 really a dead pin? Or is a surround/bass speaker or such? thanks, Takashi > > Signed-off-by: Jian-Hong Pan > --- > sound/pci/hda/patch_realtek.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index e333b3e30e31..0a1fa99a6723 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5797,6 +5797,7 @@ enum { > ALC286_FIXUP_ACER_AIO_HEADSET_MIC, > ALC256_FIXUP_ASUS_MIC_NO_PRESENCE, > ALC299_FIXUP_PREDATOR_SPK, > + ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -6837,6 +6838,16 @@ static const struct hda_fixup alc269_fixups[] = { > { } > } > }, > + [ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC] = { > + .type = HDA_FIXUP_PINS, > + .v.pins = (const struct hda_pintbl[]) { > + { 0x14, 0x411111f0 }, /* disable confusing internal speaker */ > + { 0x19, 0x04a11150 }, /* use as headset mic, without its own jack detect */ > + { } > + }, > + .chained = true, > + .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -6995,6 +7006,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK), > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC), > + SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW), > SND_PCI_QUIRK(0x1043, 0x1a30, "ASUS X705UD", ALC256_FIXUP_ASUS_MIC), > SND_PCI_QUIRK(0x1043, 0x1b13, "Asus U41SV", ALC269_FIXUP_INV_DMIC), > -- > 2.20.1 > >