mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Tony Lindgren <tony@atomide.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] Regression in next with codec unload and      snd_soc_component_get/put
Date: Fri, 09 Aug 2019 09:25:11 +0200	[thread overview]
Message-ID: <s5hwofmhkbs.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190809070003.GA52127@atomide.com>

On Fri, 09 Aug 2019 09:00:03 +0200,
Tony Lindgren wrote:
> 
> Hi,
> 
> Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add
> snd_soc_component_get/put()") causes a regression where trying
> to rmmod a codec driver fails with module is in use error after
> rmmod of snd-soc-audio-graph-card for example.
> 
> Any ideas what goes wrong there?

There is an obvious typo: soc_cleanup_component() should call
snd_soc_component_module_put_when_remove() instead of *_close().

And the module_get_upon_open boolean switch is a bit hard to
understand.  Maybe using enum would be simpler there.

> BTW, looks like the lore.kernel.org link in that commit also is
> unreachable?

It's because alsa-devel ML isn't tracked on lore.kernel.org,
unfortunately.

Jaroslav, I asked this already.  Shall we ask lore to track alsa-devel
ML?
  https://korg.wiki.kernel.org/userdoc/lore


thanks,

Takashi

  reply	other threads:[~2019-08-09  7:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  7:00 Tony Lindgren
2019-08-09  7:25 ` Takashi Iwai [this message]
2019-08-09  7:46   ` [alsa-devel] " Tony Lindgren
2019-08-09  8:23     ` Takashi Iwai
2019-08-13 10:24       ` Tony Lindgren
2019-08-13 11:29         ` Mark Brown
2019-08-13 14:07           ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwofmhkbs.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome