From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB20C4321A for ; Fri, 28 Jun 2019 08:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EB33208C4 for ; Fri, 28 Jun 2019 08:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbfF1Ih6 (ORCPT ); Fri, 28 Jun 2019 04:37:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:45264 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726056AbfF1Ih6 (ORCPT ); Fri, 28 Jun 2019 04:37:58 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2B8A9AE2D; Fri, 28 Jun 2019 08:37:57 +0000 (UTC) Date: Fri, 28 Jun 2019 10:37:56 +0200 Message-ID: From: Takashi Iwai To: "Colin King" Cc: , "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: usb-audio: fix sign unintended sign extension on left shifts In-Reply-To: <20190627164308.21286-1-colin.king@canonical.com> References: <20190627164308.21286-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Jun 2019 18:43:08 +0200, Colin King wrote: > > From: Colin Ian King > > There are a couple of left shifts of unsigned 8 bit values that > first get promoted to signed ints and hence get sign extended > on the shift if the top bit of the 8 bit values are set. Fix > this by casting the 8 bit values to unsigned ints to stop the > unintentional sign extension. > > Addresses-Coverity: ("Unintended sign extension") > Signed-off-by: Colin Ian King Applied now. Thanks. Takashi