From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757306AbcHWNpm (ORCPT ); Tue, 23 Aug 2016 09:45:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:38160 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753533AbcHWNpk (ORCPT ); Tue, 23 Aug 2016 09:45:40 -0400 Date: Tue, 23 Aug 2016 15:45:38 +0200 Message-ID: From: Takashi Iwai To: "Luis Henriques" Cc: "Krishnankutty Kolathappilly" , , "Vinod Koul" , "Jaroslav Kysela" , Subject: Re: ALSA: compress: Memset timestamp structure to zero. In-Reply-To: <1471959637-18163-2-git-send-email-luis.henriques@canonical.com> References: <1471959637-18163-1-git-send-email-luis.henriques@canonical.com> <1471959637-18163-2-git-send-email-luis.henriques@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Aug 2016 15:40:37 +0200, Luis Henriques wrote: > > From: Krishnankutty Kolathappilly > > snd_compr_tstamp is initialized using aggregate initialization > that does not zero out the padded bytes. Initialize timestamp > structure to zero using memset to avoid this. > > CRs-Fixed: 568717 > Change-Id: I7a7d188705161f06201f1a1f2945bb6acd633d5d > Signed-off-by: Krishnankutty Kolathappilly Vinod already informed me about this, and we agreed that it doesn't make any sense. What does it really fix? thanks, Takashi > --- > sound/core/compress_offload.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c > index 2c498488af6c..84aaa07ca853 100644 > --- a/sound/core/compress_offload.c > +++ b/sound/core/compress_offload.c > @@ -659,9 +659,10 @@ snd_compr_set_metadata(struct snd_compr_stream *stream, unsigned long arg) > static inline int > snd_compr_tstamp(struct snd_compr_stream *stream, unsigned long arg) > { > - struct snd_compr_tstamp tstamp = {0}; > + struct snd_compr_tstamp tstamp; > int ret; > > + memset(&tstamp, 0, sizeof(tstamp)); > ret = snd_compr_update_tstamp(stream, &tstamp); > if (ret == 0) > ret = copy_to_user((struct snd_compr_tstamp __user *)arg, >