From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752576AbcBEJ1I (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Feb 2016 04:27:08 -0500
Received: from mx2.suse.de ([195.135.220.15]:55037 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752400AbcBEJ1E (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Feb 2016 04:27:04 -0500
Date: Fri, 05 Feb 2016 10:26:59 +0100
Message-ID: <s5hwpqj1p98.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Joonsoo Kim" <js1304@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
        "Christian Borntraeger" <borntraeger@de.ibm.com>,
        "Chris Metcalf" <cmetcalf@ezchip.com>,
        "David Rientjes" <rientjes@google.com>,
        "Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
        <linux-mm@kvack.org>, "Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
        "Christoph Lameter" <cl@linux.com>, <linux-api@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] sound: query dynamic DEBUG_PAGEALLOC setting
In-Reply-To: <1454565386-10489-4-git-send-email-iamjoonsoo.kim@lge.com>
References: <1454565386-10489-1-git-send-email-iamjoonsoo.kim@lge.com>
	<1454565386-10489-4-git-send-email-iamjoonsoo.kim@lge.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 04 Feb 2016 06:56:24 +0100,
Joonsoo Kim wrote:
> 
> We can disable debug_pagealloc processing even if the code is complied
> with CONFIG_DEBUG_PAGEALLOC. This patch changes the code to query
> whether it is enabled or not in runtime.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Takashi Iwai <tiwai@suse.de>


Takashi


> ---
>  sound/drivers/pcsp/pcsp.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/drivers/pcsp/pcsp.c b/sound/drivers/pcsp/pcsp.c
> index 27e25bb..72e2d00 100644
> --- a/sound/drivers/pcsp/pcsp.c
> +++ b/sound/drivers/pcsp/pcsp.c
> @@ -14,6 +14,7 @@
>  #include <linux/input.h>
>  #include <linux/delay.h>
>  #include <linux/bitops.h>
> +#include <linux/mm.h>
>  #include "pcsp_input.h"
>  #include "pcsp.h"
>  
> @@ -148,11 +149,11 @@ static int alsa_card_pcsp_init(struct device *dev)
>  		return err;
>  	}
>  
> -#ifdef CONFIG_DEBUG_PAGEALLOC
>  	/* Well, CONFIG_DEBUG_PAGEALLOC makes the sound horrible. Lets alert */
> -	printk(KERN_WARNING "PCSP: CONFIG_DEBUG_PAGEALLOC is enabled, "
> -	       "which may make the sound noisy.\n");
> -#endif
> +	if (debug_pagealloc_enabled()) {
> +		printk(KERN_WARNING "PCSP: CONFIG_DEBUG_PAGEALLOC is enabled, "
> +		       "which may make the sound noisy.\n");
> +	}
>  
>  	return 0;
>  }
> -- 
> 1.9.1
> 
>