From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755036AbbCFQDP (ORCPT ); Fri, 6 Mar 2015 11:03:15 -0500 Received: from cantor2.suse.de ([195.135.220.15]:50498 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754687AbbCFQDM (ORCPT ); Fri, 6 Mar 2015 11:03:12 -0500 Date: Fri, 06 Mar 2015 17:03:06 +0100 Message-ID: From: Takashi Iwai To: "Maciej S. Szmigiero" Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela Subject: Re: [PATCH]Add VT1613 AC97 codec support In-Reply-To: <54F9CEC4.9020305@maciej.szmigiero.name> References: <54F9CEC4.9020305@maciej.szmigiero.name> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 06 Mar 2015 16:59:00 +0100, Maciej S. Szmigiero wrote: > > Patch to add an VT1613 AC97 codec support. > > This codec has additional DC offset removal control, > headphone output and no video input. > > Signed-off-by: Maciej Szmigiero Applied, thanks. Takashi > > diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c > index 5ee2f17..5bca1a3 100644 > --- a/sound/pci/ac97/ac97_codec.c > +++ b/sound/pci/ac97/ac97_codec.c > @@ -177,6 +177,7 @@ static const struct ac97_codec_id snd_ac97_codec_ids[] = { > { 0x54524123, 0xffffffff, "TR28602", NULL, NULL }, // only guess --jk [TR28023 = eMicro EM28023 (new CT1297)] > { 0x54584e03, 0xffffffff, "TLV320AIC27", NULL, NULL }, > { 0x54584e20, 0xffffffff, "TLC320AD9xC", NULL, NULL }, > +{ 0x56494120, 0xfffffff0, "VIA1613", patch_vt1613, NULL }, > { 0x56494161, 0xffffffff, "VIA1612A", NULL, NULL }, // modified ICE1232 with S/PDIF > { 0x56494170, 0xffffffff, "VIA1617A", patch_vt1617a, NULL }, // modified VT1616 with S/PDIF > { 0x56494182, 0xffffffff, "VIA1618", patch_vt1618, NULL }, > diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c > index ceaac1c..eca2210 100644 > --- a/sound/pci/ac97/ac97_patch.c > +++ b/sound/pci/ac97/ac97_patch.c > @@ -3352,6 +3352,39 @@ static int patch_cm9780(struct snd_ac97 *ac97) > } > > /* > + * VIA VT1613 codec > + */ > +static const struct snd_kcontrol_new snd_ac97_controls_vt1613[] = { > +AC97_SINGLE("DC Offset removal", 0x5a, 10, 1, 0), > +}; > + > +static int patch_vt1613_specific(struct snd_ac97 *ac97) > +{ > + int err; > + > + err = patch_build_controls(ac97, &snd_ac97_controls_vt1613[0], > + ARRAY_SIZE(snd_ac97_controls_vt1613)); > + if (err) > + return err; > + > + return 0; > +}; > + > +static const struct snd_ac97_build_ops patch_vt1613_ops = { > + .build_specific = patch_vt1613_specific > +}; > + > +static int patch_vt1613(struct snd_ac97 *ac97) > +{ > + ac97->build_ops = &patch_vt1613_ops; > + > + ac97->flags |= AC97_HAS_NO_VIDEO; > + ac97->caps |= AC97_BC_HEADPHONE; > + > + return 0; > +} > + > +/* > * VIA VT1616 codec > */ > static const struct snd_kcontrol_new snd_ac97_controls_vt1616[] = { >