From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753529AbaIOI2u (ORCPT ); Mon, 15 Sep 2014 04:28:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59596 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753252AbaIOI2s (ORCPT ); Mon, 15 Sep 2014 04:28:48 -0400 Date: Mon, 15 Sep 2014 10:28:44 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: pci: ctxfi: pr_* replaced with dev_* In-Reply-To: <1410518745-29983-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1410518745-29983-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 12 Sep 2014 16:15:45 +0530, Sudip Mukherjee wrote: > > pr_* macros replaced with dev_* as they are more preffered over pr_*. Now we have card->dev as its own device. Use this instead of pci->dev as much as possible. (Of course, you should be careful about the object's lifetime, too). Also... > diff --git a/sound/pci/ctxfi/ctamixer.c b/sound/pci/ctxfi/ctamixer.c > index fed6e6a..d08b8b6 100644 > --- a/sound/pci/ctxfi/ctamixer.c > +++ b/sound/pci/ctxfi/ctamixer.c > @@ -258,7 +258,8 @@ static int get_amixer_rsc(struct amixer_mgr *mgr, > } > spin_unlock_irqrestore(&mgr->mgr_lock, flags); > if (err) { > - pr_err("ctxfi: Can't meet AMIXER resource request!\n"); > + dev_err(&(((struct hw *)(mgr->mgr.hw))->pci->dev), > + "ctxfi: Can't meet AMIXER resource request!\n"); ... please re-read and consider twice before submitting your patch, whether such a change is really good or not. thanks, Takashi