From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423096Ab2CPP5k (ORCPT ); Fri, 16 Mar 2012 11:57:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60186 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422814Ab2CPP5j (ORCPT ); Fri, 16 Mar 2012 11:57:39 -0400 Date: Fri, 16 Mar 2012 16:57:36 +0100 Message-ID: From: Takashi Iwai To: Lucas De Marchi Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kay.sievers@vrfy.org, rdunlap@xenotime.net, mchehab@infradead.org, perex@perex.cz, hjlipp@web.de, davem@davemloft.net, w.sang@pengutronix.de Subject: Re: [PATCH] Remove references to /etc/modprobe.conf In-Reply-To: References: <1331908876-1268-1-git-send-email-lucas.demarchi@profusion.mobi> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 16 Mar 2012 12:51:46 -0300, Lucas De Marchi wrote: > > Hi Takahashi, > > On Fri, Mar 16, 2012 at 11:51 AM, Takashi Iwai wrote: > > At Fri, 16 Mar 2012 11:41:16 -0300, > > Lucas De Marchi wrote: > >> > >> Usage of /etc/modprobe.conf file was deprecated by module-init-tools and > >> is no longer parsed by new kmod tool. References to this file are > >> replaced in Documentation, comments and Kconfig according to the > >> context. > >> > >> There are also some references to the old /etc/modules.conf from 2.4 > >> kernels that are being removed. > >> > >> Signed-off-by: Lucas De Marchi > > > > It's nice to correct the document, but the change like > > > > -  /etc/modprobe.conf to ensure that the aoe module is loaded when > > +  /etc/modprobe.d/aoe.conf to ensure that the aoe module is loaded when > > > > might be misleading since it looks as if the fixed config file name > > must be used. > > What text do you prefer here? I used a mix of them throughout the > patch. Generally when text said it was giving an example I used a > fixed filename. Otherwise I used "/etc/modprobe.d/*.conf" or "a > configuration file in /etc/modprobe.d/" I think better to stick with an ambiguous name like the last two above. OK, in the case of aoe.conf, you have a script, so it should be fine. But floppy.conf, i810fb.conf, etc, are replaced from the generic modprobe.conf by no particular reason. This is what I'm concerned. > > Also, the config file name should be with a number prefix.  At least, > > it's recommended so in the recent distros to determine the loading > > order.  However, which number to be used depends on pretty much on the > > distribution. > > > > So, from both points, it'd be better to mention that it's an example > > file name. > > Could you rephrase my change so I include it in a v2 patch? If the file name isn't specified, I don't think you need to worry about it. thanks, Takashi