From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755829Ab1FXNPD (ORCPT ); Fri, 24 Jun 2011 09:15:03 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34428 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752066Ab1FXNPA (ORCPT ); Fri, 24 Jun 2011 09:15:00 -0400 Date: Fri, 24 Jun 2011 15:14:59 +0200 Message-ID: From: Takashi Iwai To: Ralf Baechle Cc: Mauro Carvalho Chehab , Jaroslav Kysela , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-mips@linux-mips.org Subject: Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure In-Reply-To: <20110624130818.GC6327@linux-mips.org> References: <20110623144750.GA10180@linux-mips.org> <20110624111608.GA6327@linux-mips.org> <20110624130818.GC6327@linux-mips.org> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 24 Jun 2011 14:08:18 +0100, Ralf Baechle wrote: > > On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote: > > > > o The drivers/media/radio/Kconfig part should be applied for 3.0 and > > > maybe -stable. > > > > Yes, this will be good. > > I just tested that segment only and it works as expected. Will repost in > a minute. Great, thanks. > > > o The sound/isa/Kconfig part is basically only fixing the dependency for > > > the Adlib driver allowing it to be built on non-ISA_DMA_API system and > > > is material for the next release after 3.0. > > > > Any serious reason that snd-adlib must be built even with ISA=n? > > Definately not. > > > As the device is really present only for ISA, it doesn't make much > > sense to build this even though the driver itself doesn't need > > ISA_DMA_API. > > I'm not aware of any systems that could use the Adlib in a ISA=n > environment. That's why my patch left the dependency on ISA untouched. OK, but this would just make things complex, I'm afraid. Practically the only user of snd-adlib is the old x86 with ISA support, which implies ISA_DMA_API=y, too. Thus I don't want to touch sound/isa/Kconfig just for snd-adlib being built for some funky Kconfig setup :) thanks, Takashi