From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756885AbZJ3KOk@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756885AbZJ3KOk (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Oct 2009 06:14:40 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756714AbZJ3KOj
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 30 Oct 2009 06:14:39 -0400
Received: from cantor.suse.de ([195.135.220.2]:39560 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756707AbZJ3KOj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Oct 2009 06:14:39 -0400
Date: Fri, 30 Oct 2009 11:14:43 +0100
Message-ID: <s5hws2dyyr0.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] param: use free hook for charp
In-Reply-To: <20091022142342.14D378655F@mx2.suse.de>
References: <20091022142342.14D378655F@mx2.suse.de>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rusty,

sorry for the delayed reply; I finally got back to work now.

At Fri, 23 Oct 2009 00:51:29 +1030,
Rusty Russell wrote:
> 
> 
> Instead of using a "I kmalloced this" flag, we keep track of the kmalloced
> strings and use that list to check if we need to kfree (in practice, the
> list is very short).
> 
> This means that kparams can be const again.
> 
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This is indeed a simple solution!  I like it.


thanks,

Takashi