mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sven Eckelmann <sven.eckelmann@gmx.de>
Cc: Jaroslav Kysela <perex@perex.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctxfi: Swapped SURROUND-SIDE mute
Date: Fri, 02 Oct 2009 07:47:03 +0200	[thread overview]
Message-ID: <s5hws3el548.wl%tiwai@suse.de> (raw)
In-Reply-To: <1254420399-14411-1-git-send-email-sven.eckelmann@gmx.de>

At Thu,  1 Oct 2009 20:06:39 +0200,
Sven Eckelmann wrote:
> 
> On Soundblaster X-FI Titenium with emu20k2 the SIDE and SURROUND mute
> functions are swapped.
> It was checked with 'speaker-test -c 8 -s 3' and (un)mute surround or
> 'speaker-test -c 8 -s 7' and (un)mute side. The volume seems not
> to be affected and works as expected.
> 
> Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
> ---
> This patch is tested with commit 55fe27f7e2c9d24ce870136bd99ae67b020122d1
> which arranges the channels on emu20k2.

Thanks, applied now.


Takashi

>  sound/pci/ctxfi/ctatc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
> index b1b3a64..7545464 100644
> --- a/sound/pci/ctxfi/ctatc.c
> +++ b/sound/pci/ctxfi/ctatc.c
> @@ -1037,7 +1037,7 @@ static int atc_line_front_unmute(struct ct_atc *atc, unsigned char state)
>  
>  static int atc_line_surround_unmute(struct ct_atc *atc, unsigned char state)
>  {
> -	return atc_daio_unmute(atc, state, LINEO4);
> +	return atc_daio_unmute(atc, state, LINEO2);
>  }
>  
>  static int atc_line_clfe_unmute(struct ct_atc *atc, unsigned char state)
> @@ -1047,7 +1047,7 @@ static int atc_line_clfe_unmute(struct ct_atc *atc, unsigned char state)
>  
>  static int atc_line_rear_unmute(struct ct_atc *atc, unsigned char state)
>  {
> -	return atc_daio_unmute(atc, state, LINEO2);
> +	return atc_daio_unmute(atc, state, LINEO4);
>  }
>  
>  static int atc_line_in_unmute(struct ct_atc *atc, unsigned char state)
> -- 
> 1.6.4.3
> 

      reply	other threads:[~2009-10-02  5:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01 18:06 Sven Eckelmann
2009-10-02  5:47 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hws3el548.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sven.eckelmann@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®