mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: Re: No more Intel HDA soundcard
Date: Sun, 01 Mar 2009 11:00:35 +0100	[thread overview]
Message-ID: <s5hwsb9r29o.wl%tiwai@suse.de> (raw)
In-Reply-To: <20090228184412.GA2333@x200.localdomain>

At Sat, 28 Feb 2009 21:44:12 +0300,
Alexey Dobriyan wrote:
> 
> The following commit results in soundcard detection failing with -EBUSY
> 
> commit 34c25350acfc792747e861d1e36874abf7e73255
> Author: Takashi Iwai <tiwai@suse.de>
> Date:   Tue Oct 28 11:38:58 2008 +0100
> 
>     ALSA: hda - Remove old codec-probe limitation
>     
>     Removed the old workaround to avoid the non-existing codec slot.
>     The current code should work without that workaround.  If any,
>     we can add a quirk table.
>     
>     Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> I fixed up this (and got sound back) but suspect the following is not right.
> 
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -1224,6 +1224,7 @@ static void azx_stop_chip(struct azx *chip);
>  
>  /* number of codec slots for each chipset: 0 = default slots (i.e. 4) */
>  static unsigned int azx_max_codecs[AZX_NUM_DRIVERS] __devinitdata = {
> +	[AZX_DRIVER_ICH] = 3,
>  	[AZX_DRIVER_TERA] = 1,
>  };

Right, it's no good solution as you expected ;)
The problem is that your patch will disable the all HDMI devices that are
newly supported on 2.6.29.

Is your machine Toshiba X200, found in bug 12735 ??
	http://bugzilla.kernel.org/show_bug.cgi?id=12735

If yes, could you try the patch below?

Also, it'd be helpful if you can try sound git tree (master branch):
    git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
that contains the very latest driver.  This should work as is.


thanks,

Takashi

---
>From ea525d89f74737ebc3674184c6d3c30f9e7c7a6f Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Sun, 1 Mar 2009 10:55:44 +0100
Subject: [PATCH] ALSA: hda - Add probe_mask default for Toshiba laptop with ALC268

Some Toshiba laptops have another ALC268 codec on slot#3 that conflicts
with the primary codec.  The codec#3 is for the digital I/O, and should
be fixed by the driver, but it'd need a bunch of changes.

So, let's fix the probe problem temporarily by setting the default
probe_mask value.

Reference: kernel bugzilla #12735
	http://bugzilla.kernel.org/show_bug.cgi?id=12735

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/hda_intel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index c8d9178..5e909e0 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2095,6 +2095,8 @@ static struct snd_pci_quirk probe_mask_list[] __devinitdata = {
 	SND_PCI_QUIRK(0x1028, 0x20ac, "Dell Studio Desktop", 0x01),
 	/* including bogus ALC268 in slot#2 that conflicts with ALC888 */
 	SND_PCI_QUIRK(0x17c0, 0x4085, "Medion MD96630", 0x01),
+	/* conflict of ALC268 in slot#3 (digital I/O); a temporary fix */
+	SND_PCI_QUIRK(0x1179, 0xff00, "Toshiba laptop", 0x03),
 	{}
 };
 
-- 
1.6.1.3


  reply	other threads:[~2009-03-01 10:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-28 18:44 Alexey Dobriyan
2009-03-01 10:00 ` Takashi Iwai [this message]
2009-03-01 10:41   ` Alexey Dobriyan
2009-03-01 20:25     ` Takashi Iwai
2009-03-01 21:02       ` Alexey Dobriyan
2009-03-02  7:10         ` Takashi Iwai
2009-03-01 21:18       ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwsb9r29o.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®