From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756353AbZBTHn3 (ORCPT ); Fri, 20 Feb 2009 02:43:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753107AbZBTHnV (ORCPT ); Fri, 20 Feb 2009 02:43:21 -0500 Received: from cantor.suse.de ([195.135.220.2]:53575 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752871AbZBTHnU (ORCPT ); Fri, 20 Feb 2009 02:43:20 -0500 Date: Fri, 20 Feb 2009 08:43:19 +0100 Message-ID: From: Takashi Iwai To: Harvey Harrison Cc: LKML Subject: Re: [PATCH] sound: pcxhr.h replace signed one-bit bitfields In-Reply-To: <1235073517.4377.5.camel@brick> References: <1235073517.4377.5.camel@brick> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 19 Feb 2009 11:58:37 -0800, Harvey Harrison wrote: > > The usage and comments make it clear values of 1/0 were intended > rather than -1/0 > > Noticed by sparse: > sound/pci/pcxhr/pcxhr.h:100:20: error: dubious one-bit signed bitfield > sound/pci/pcxhr/pcxhr.h:101:22: error: dubious one-bit signed bitfield > sound/pci/pcxhr/pcxhr.h:102:24: error: dubious one-bit signed bitfield > sound/pci/pcxhr/pcxhr.h:103:21: error: dubious one-bit signed bitfield > sound/pci/pcxhr/pcxhr.h:104:25: error: dubious one-bit signed bitfield > sound/pci/pcxhr/pcxhr.h:105:20: error: dubious one-bit signed bitfield > > Signed-off-by: Harvey Harrison Applied now. Thanks! Takashi > --- > sound/pci/pcxhr/pcxhr.h | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/sound/pci/pcxhr/pcxhr.h b/sound/pci/pcxhr/pcxhr.h > index ac9c3b3..a661a18 100644 > --- a/sound/pci/pcxhr/pcxhr.h > +++ b/sound/pci/pcxhr/pcxhr.h > @@ -97,12 +97,12 @@ struct pcxhr_mgr { > int capture_chips; > int fw_file_set; > int firmware_num; > - int is_hr_stereo:1; > - int board_has_aes1:1; /* if 1 board has AES1 plug and SRC */ > - int board_has_analog:1; /* if 0 the board is digital only */ > - int board_has_mic:1; /* if 1 the board has microphone input */ > - int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */ > - int mono_capture:1; /* if 1 the board does mono capture */ > + unsigned int is_hr_stereo:1; > + unsigned int board_has_aes1:1; /* if 1 board has AES1 plug and SRC */ > + unsigned int board_has_analog:1; /* if 0 the board is digital only */ > + unsigned int board_has_mic:1; /* if 1 the board has microphone input */ > + unsigned int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */ > + unsigned int mono_capture:1; /* if 1 the board does mono capture */ > > struct snd_dma_buffer hostport; > > -- > 1.6.2.rc1.175.g96b8a > > >