mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Gerhard Pircher" <gerhard_pircher@gmx.net>
Cc: linux-kernel@vger.kernel.org, alsa-devel@lists.sourceforge.net,
	rlrevell@joe-job.com, linuxppc-dev@ozlabs.org
Subject: Re: [Alsa-devel] RFC: dma_mmap_coherent() for powerpc/ppc architecture and ALSA?
Date: Fri, 30 Jun 2006 11:12:00 +0200	[thread overview]
Message-ID: <s5hwtaz9fdr.wl%tiwai@suse.de> (raw)
In-Reply-To: <20060629211513.64980@gmx.net>

At Thu, 29 Jun 2006 23:15:13 +0200,
Gerhard Pircher wrote:
> 
> 
> -------- Original-Nachricht --------
> Datum: Thu, 29 Jun 2006 11:27:15 +0200
> Von: Takashi Iwai <tiwai@suse.de>
> An: Gerhard Pircher <gerhard_pircher@gmx.net>
> Betreff: Re: [Alsa-devel] RFC: dma_mmap_coherent() for powerpc/ppc architecture and ALSA?
> 
> > At Wed, 28 Jun 2006 22:27:53 +0200,
> > Gerhard Pircher wrote:
> > > 
> > > Hi,
> > > 
> > > It took a little bit longer to integrate the patch, as I didn't figure
> > out  first how to implement the __dma_mmap_coherent() function for PPC
> > systems with CONFIG_NOT_COHERENT_CACHE defined. :)
> > > 
> > > Unfortunately my system still crashes within snd_pcm_mmap_data_nopage() 
> > > (sound/core/pcm_native.c), as you can see below. I guess it tries to
> > remap 
> > > a DMA buffer allocated by the not cache coherent DMA memory allocation 
> > > function in arch/ppc/kernel/dma-mapping.c.
> > 
> > Strange, nopage will be never called if you apply my patch and modify
> > to use dma_mmap_coherent().
> > 
> > 
> > Takashi
> > 
> That's indeed strange! I'm sure that the new code is called by the
> sound drivers. Should snd_pcm_mmap_data_nopage() not be used at all
> anymore, or are there any cases that could still trigger a call of
> snd_pcm_mmap_data_nopage()? 

What is the type of buffer are you using?  If it's a buffer
pre-allocated via snd_pcm_lib_preallocate*() with SNDRV_DMA_TYPE_DEV,
there should be no snd_pcm_mmap_data_nopage call.  For other types,
there can be.  For example, the patch still doesn't solve the problems
with drivers using sg-buffer.


Takashi

  reply	other threads:[~2006-06-30  9:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 20:27 Gerhard Pircher
2006-06-29  9:27 ` Takashi Iwai
2006-06-29 21:15   ` Gerhard Pircher
2006-06-30  9:12     ` Takashi Iwai [this message]
2006-06-30 18:21       ` Gerhard Pircher
  -- strict thread matches above, loose matches on Subject: below --
2006-06-10  8:22 Gerhard Pircher
2006-06-12 10:51 ` Takashi Iwai
2006-06-12 14:42   ` Gerhard Pircher
2006-06-14 14:42     ` [Alsa-devel] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwtaz9fdr.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=gerhard_pircher@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=rlrevell@joe-job.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®